Details

Reviewers

grehan
manu

Group Reviewers

bhyve

Commits

rG366b4fc2d569: bhyve: move 64 bit BAR location to match OVMF assumptions
rG4a4053e1b053: bhyve: move 64 bit BAR location to match OVMF assumptions

Summary

OVMF will fail, if large 64 bit BARs are used. GCD-Map doesn't cover 64 bit addresses of BARs.
OVMF assumes that 64 bit addresses of BARS are located on next 32 GB boundary behind Top of High RAM.
See D27230

This patch moves 64 bit BARs on next 32 GB boundary behind Top of High RAM to match OVMF assumptions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

corvink created this revision.Jan 5 2021, 11:16 AM

Herald added subscribers: bcran, rgrimes. · View Herald TranscriptJan 5 2021, 11:16 AM

corvink requested review of this revision.Jan 5 2021, 11:16 AM

OVMF puts it at the next 16GB boundary, which might be better.

The alignment depends on gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size which is set in BhyveX64.dsc. On my system with 4 GB of RAM, it's set to 32 GB:
GetFirstNonAddress: Pci64Base=0x800000000 Pci64Size=0x800000000

Revert rS367606 "bhyve: avoid allocating BARs above the end of supported physical addresses."

This works for me. I was seeing an assert failure in pci_emul.c, but it disappeared for some reason.
One person on Slack said they'd like the BAR in a fixed (high) location, so I wouldn't be confident committing this without other people (e.g. @jhb and @grehan ) reviewing it too.

The patch no longer applies against 13-CURRENT: I needed to apply several lines manually.

bcran added a subscriber: grehan.Jan 16 2021, 6:28 AM

Rebase onto 13-CURRENT

corvink mentioned this in D26209: GVT-d support for bhyve.Jan 22 2021, 10:52 AM

In D27970#630024, @bcran wrote:

One person on Slack said they'd like the BAR in a fixed (high) location, so I wouldn't be confident committing this without other people (e.g. @jhb and @grehan ) reviewing it too.

What's the current state? Should the BARs be located at a fixed (high) location or not?

emaste added a subscriber: emaste.Mar 29 2021, 1:33 PM

rebase on upstream/main

corvink added reviewers: grehan, manu.Nov 17 2021, 11:28 AM

corvink set the repository for this revision to rG FreeBSD src repository.

Herald added a subscriber: imp. · View Herald TranscriptNov 17 2021, 11:28 AM

LGTM.
Will commit next monday unless someone have more comments until then.
Almost a year since a question was asked and no answer was given, if people prefer a high fixed address they have until monday to raise their hand.

manu accepted this revision.Nov 18 2021, 5:50 PM

This revision is now accepted and ready to land.Nov 18 2021, 5:50 PM

Closed by commit rG4a4053e1b053: bhyve: move 64 bit BAR location to match OVMF assumptions (authored by corvink, committed by manu). · Explain WhyNov 22 2021, 3:30 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG4a4053e1b053: bhyve: move 64 bit BAR location to match OVMF assumptions.

manu added a commit: rG366b4fc2d569: bhyve: move 64 bit BAR location to match OVMF assumptions.Jan 14 2022, 2:21 PM