Page MenuHomeFreeBSD
Differential D27828

Use kdb_thr_from_pid() in db_lookup_thread().
ClosedPublic
Actions

Authored by jhb on Dec 29 2020, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 8:31 AM
Unknown Object (File)
Sat, Nov 23, 4:09 AM
Unknown Object (File)
Fri, Nov 15, 9:04 PM
Unknown Object (File)
Fri, Nov 8, 9:55 PM
Unknown Object (File)
Thu, Nov 7, 12:32 PM
Unknown Object (File)
Oct 29 2024, 1:07 PM
Unknown Object (File)
Oct 25 2024, 4:24 PM
Unknown Object (File)
Oct 18 2024, 10:50 PM
View All 63 Files
Subscribers
imp

Details

Reviewers
kib
mjg
Commits
rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread().
Summary

The code is identical, so this should be a no-op.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35770
Build 32659: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 29 2020, 11:52 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 29 2020, 11:52 PM
jhb requested review of this revision.Dec 29 2020, 11:52 PM
Harbormaster completed remote builds in B35770: Diff 81344.Dec 29 2020, 11:52 PM
jhb added a parent revision: D27827: Don't check P_INMEM in kdb_thr_*()..Dec 29 2020, 11:52 PM
jhb added a child revision: D27829: Use kdb_thr_* to iterate over threads consistently in DDB..
kib accepted this revision.Dec 30 2020, 1:06 PM

Would it be improvement to check addr with IN_KERNEL() before assuming that it is the thread address ?

This revision is now accepted and ready to land.Dec 30 2020, 1:06 PM
jhb added a comment.Dec 30 2020, 7:01 PM

Yes, doing INKERNEL() checks for both of these helpers likely makes sense, though I think as a separate commit.

Closed by commit rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread(). (authored by jhb). · Explain WhyJan 1 2021, 12:04 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread()..

Revision Contents
Changeset List

PathSize
sys/
ddb/
8 lines

Diff 81344

View Options

sys/ddb/db_thread.c

Loading...