Page MenuHomeFreeBSD
Differential D27828

Use kdb_thr_from_pid() in db_lookup_thread().
ClosedPublic
Actions

Authored by jhb on Dec 29 2020, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 4:40 AM
Unknown Object (File)
Mar 5 2025, 6:06 PM
Unknown Object (File)
Feb 22 2025, 5:33 AM
Unknown Object (File)
Feb 16 2025, 5:56 PM
Unknown Object (File)
Dec 30 2024, 5:17 PM
Unknown Object (File)
Nov 25 2024, 8:31 AM
Unknown Object (File)
Nov 23 2024, 4:09 AM
Unknown Object (File)
Nov 15 2024, 9:04 PM
View All 68 Files
Subscribers
imp

Details

Reviewers
kib
mjg
Commits
rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread().
Summary

The code is identical, so this should be a no-op.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35770
Build 32659: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 29 2020, 11:52 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 29 2020, 11:52 PM
jhb requested review of this revision.Dec 29 2020, 11:52 PM
Harbormaster completed remote builds in B35770: Diff 81344.Dec 29 2020, 11:52 PM
jhb added a parent revision: D27827: Don't check P_INMEM in kdb_thr_*()..Dec 29 2020, 11:52 PM
jhb added a child revision: D27829: Use kdb_thr_* to iterate over threads consistently in DDB..
kib accepted this revision.Dec 30 2020, 1:06 PM

Would it be improvement to check addr with IN_KERNEL() before assuming that it is the thread address ?

This revision is now accepted and ready to land.Dec 30 2020, 1:06 PM
jhb added a comment.Dec 30 2020, 7:01 PM

Yes, doing INKERNEL() checks for both of these helpers likely makes sense, though I think as a separate commit.

Closed by commit rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread(). (authored by jhb). · Explain WhyJan 1 2021, 12:04 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread()..

Revision Contents
Changeset List

PathSize
sys/
ddb/
8 lines

Diff 81344

View Options

sys/ddb/db_thread.c

Show First 20 Lines • Show All 668 Lines • ▼ Show 20 Lines if (info.rti_info[RTAX_GATEWAY] != NULL &&
} }
} }
switch (rtm->rtm_type) { switch (rtm->rtm_type) {
struct rtentry *saved_nrt; struct rtentry *saved_nrt;
case RTM_ADD: case RTM_ADD:
case RTM_CHANGE: case RTM_CHANGE:
if (rtm->rtm_type == RTM_ADD) {
if (info.rti_info[RTAX_GATEWAY] == NULL) if (info.rti_info[RTAX_GATEWAY] == NULL)
senderr(EINVAL); senderr(EINVAL);
}
saved_nrt = NULL; saved_nrt = NULL;
/* support for new ARP code */ /* support for new ARP code */
if (info.rti_info[RTAX_GATEWAY]->sa_family == AF_LINK && if (info.rti_info[RTAX_GATEWAY] != NULL &&
info.rti_info[RTAX_GATEWAY]->sa_family == AF_LINK &&
(rtm->rtm_flags & RTF_LLDATA) != 0) { (rtm->rtm_flags & RTF_LLDATA) != 0) {
error = lla_rt_output(rtm, &info); error = lla_rt_output(rtm, &info);
#ifdef INET6 #ifdef INET6
if (error == 0) if (error == 0)
rti_need_deembed = (V_deembed_scopeid) ? 1 : 0; rti_need_deembed = (V_deembed_scopeid) ? 1 : 0;
#endif #endif
break; break;
} }
error = rtrequest1_fib(rtm->rtm_type, &info, &saved_nrt, error = rtrequest1_fib(rtm->rtm_type, &info, &saved_nrt,
fibnum); fibnum);
if (error == 0 && saved_nrt != NULL) { if (error == 0 && saved_nrt != NULL) {
#ifdef INET6 #ifdef INET6
rti_need_deembed = (V_deembed_scopeid) ? 1 : 0; rti_need_deembed = (V_deembed_scopeid) ? 1 : 0;
#endif #endif
RT_LOCK(saved_nrt); RT_LOCK(saved_nrt);
rtm->rtm_index = saved_nrt->rt_ifp->if_index; rtm->rtm_index = saved_nrt->rt_ifp->if_index;
▲ Show 20 Lines • Show All 1,269 Lines • Show Last 20 Lines