Page MenuHomeFreeBSD

Use kdb_thr_from_pid() in db_lookup_thread().
ClosedPublic

Authored by jhb on Dec 29 2020, 11:52 PM.

Details

Summary

The code is identical, so this should be a no-op.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Dec 29 2020, 11:52 PM

Would it be improvement to check addr with IN_KERNEL() before assuming that it is the thread address ?

This revision is now accepted and ready to land.Dec 30 2020, 1:06 PM

Yes, doing INKERNEL() checks for both of these helpers likely makes sense, though I think as a separate commit.

This revision was automatically updated to reflect the committed changes.