Use kdb_thr_from_pid() in db_lookup_thread().
ClosedPublic
Actions

Authored by jhb on Dec 29 2020, 11:52 PM.

Tags

None

Referenced Files

	F162279933: D27828.id81344.diff
	Sat, Jul 11, 4:04 PM

	Unknown Object (File)
	Sun, Jul 5, 2:09 AM

	Unknown Object (File)
	Wed, Jun 24, 7:42 AM

	Unknown Object (File)
	Sun, Jun 21, 5:12 PM

	Unknown Object (File)
	Wed, Jun 17, 2:07 AM

	Unknown Object (File)
	Jun 12 2026, 4:07 AM

	Unknown Object (File)
	Jun 11 2026, 7:54 PM

	Unknown Object (File)
	May 26 2026, 3:19 AM

View All Files

Subscribers

imp

Details

Reviewers

kib
mjg

Commits

rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread().

Summary

The code is identical, so this should be a no-op.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 29 2020, 11:52 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2020, 11:52 PM

jhb requested review of this revision.Dec 29 2020, 11:52 PM

Harbormaster completed remote builds in B35770: Diff 81344.Dec 29 2020, 11:52 PM

jhb added a parent revision: D27827: Don't check P_INMEM in kdb_thr_*()..Dec 29 2020, 11:52 PM

jhb added a child revision: D27829: Use kdb_thr_* to iterate over threads consistently in DDB..

Would it be improvement to check addr with IN_KERNEL() before assuming that it is the thread address ?

This revision is now accepted and ready to land.Dec 30 2020, 1:06 PM

Yes, doing INKERNEL() checks for both of these helpers likely makes sense, though I think as a separate commit.

Closed by commit rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread(). (authored by jhb). · Explain WhyJan 1 2021, 12:04 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGae450907c639: Use kdb_thr_from_pid() in db_lookup_thread()..

Revision Contents
Changeset List

Path

Size

sys/

ddb/

db_thread.c

8 lines

Diff 81453

View Options

Use kdb_thr_from_pid() in db_lookup_thread().ClosedPublicActions