Use kdb_thr_* to iterate over threads consistently in DDB.
ClosedPublic
Actions

Authored by jhb on Dec 29 2020, 11:53 PM.

Tags

None

Referenced Files

	F170876686: D27829.id81345.diff
	Mon, Sep 7, 5:36 AM

	Unknown Object (File)
	Thu, Aug 27, 10:02 PM

	Unknown Object (File)
	Wed, Aug 26, 4:21 AM

	Unknown Object (File)
	Tue, Aug 25, 3:01 PM

	Unknown Object (File)
	Wed, Aug 19, 3:58 PM

	Unknown Object (File)
	Wed, Aug 19, 2:12 PM

	Unknown Object (File)
	Sun, Aug 9, 10:58 PM

	Unknown Object (File)
	Sun, Aug 9, 8:42 PM

View All Files

Subscribers

imp

Details

Reviewers

kib
mjg

Commits

rG3e06c7da020f: Use kdb_thr_* to iterate over threads consistently in DDB.

Summary

The "findstack", "show all trace", and "show active trace" commands
were iterating over allproc to enumerate threads. This missed threads
executing in exit1() after being removed from allproc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 29 2020, 11:53 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2020, 11:53 PM

Harbormaster completed remote builds in B35771: Diff 81345.Dec 29 2020, 11:53 PM

jhb requested review of this revision.Dec 29 2020, 11:53 PM

jhb added a parent revision: D27828: Use kdb_thr_from_pid() in db_lookup_thread()..

kib accepted this revision.Dec 30 2020, 1:07 PM

This revision is now accepted and ready to land.Dec 30 2020, 1:07 PM

Closed by commit rG3e06c7da020f: Use kdb_thr_* to iterate over threads consistently in DDB. (authored by jhb). · Explain WhyJan 1 2021, 12:04 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3e06c7da020f: Use kdb_thr_* to iterate over threads consistently in DDB..

Revision Contents
Changeset List

Path

Size

sys/

ddb/

db_command.c

37 lines

db_ps.c

11 lines

Diff 81454

View Options

sys/ddb/db_command.c