Don't check P_INMEM in kdb_thr_*().
ClosedPublic
Actions

Authored by jhb on Dec 29 2020, 11:52 PM.

Details

Reviewers

kib
mjg

Commits

rG825d234144c5: Don't check P_INMEM in kdb_thr_*().

Summary

Not all debugger operations that enumerate threads require thread
stacks to be resident in memory to be useful. Instead, push P_INMEM
checks (if needed) into callers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 29 2020, 11:52 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2020, 11:52 PM

jhb requested review of this revision.Dec 29 2020, 11:52 PM

Harbormaster completed remote builds in B35769: Diff 81343.Dec 29 2020, 11:52 PM

jhb added a parent revision: D27826: Enumerate processes via the pid hash table in kdb_thr_*()..Dec 29 2020, 11:52 PM

jhb added a child revision: D27828: Use kdb_thr_from_pid() in db_lookup_thread()..

kib accepted this revision.Dec 30 2020, 1:04 PM

This revision is now accepted and ready to land.Dec 30 2020, 1:04 PM

Closed by commit rG825d234144c5: Don't check P_INMEM in kdb_thr_*(). (authored by jhb). · Explain WhyJan 1 2021, 12:04 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG825d234144c5: Don't check P_INMEM in kdb_thr_*()..

Revision Contents
Changeset List

Path

Size

sys/

ddb/

db_command.c

5 lines

db_thread.c

7 lines

kern/

subr_kdb.c

15 lines

Diff 81452

View Options

sys/ddb/db_command.c

View Options

sys/ddb/db_thread.c

View Options

Don't check P_INMEM in kdb_thr_*().ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 81452

sys/ddb/db_command.c

sys/ddb/db_thread.c

sys/kern/subr_kdb.c

Don't check P_INMEM in kdb_thr_*().
ClosedPublic
Actions

Revision Contents
Changeset List