Improve caching behaviour by using counter_u64 rather than variables
shared between cores. Expect a minor performance improvement.
MFC after: 2 weeks
Sponsored by: Orange Business Services
Details
Details
- Reviewers
philip scottl - Group Reviewers
network - Commits
- rGefd9d47d0b35: pf: Convert pfi_kkif to use counter_u64
rG5a3b9507d784: pf: Convert pfi_kkif to use counter_u64
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 35675 Build 32565: arc lint + arc unit
Event Timeline
Comment Actions
Looks good, modulo minor initialisation nit/remark.
| sys/netpfil/pf/pf_if.c | ||
|---|---|---|
| 226 | Is there a point in M_ZEROing? As far as I can tell, everything is explicitly initialised later. Or you could pf_kkif_zero() to make it even clearer. | |
| sys/netpfil/pf/pf_if.c | ||
|---|---|---|
| 226 | Paranoia for one, but also because otherwise we can't tell which of the counter allocations have failed and can't safely free in pfi_kkif_free(). Happily this is not in the data path, so we don't actually do this very often. A little bit of extra memory writing here isn't going to hurt anything, | |