pf: Remove unused fields from pf_krule
ClosedPublic
Actions

Authored by kp on Dec 24 2020, 3:47 PM.

Details

Reviewers

philip
scottl

Group Reviewers

network

Commits

rG7ee74e43abb7: pf: Remove unused fields from pf_krule
rGc7bdafe2f1b7: pf: Remove unused fields from pf_krule

Summary

The u_* counters are used only to communicate with userspace, as
userspace cannot use counter_u64. As pf_krule is not passed to userspace
these fields are now obsolete.

MFC after: 2 weeks
Sponsored by: Orange Business Services

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35671
Build 32561: arc lint + arc unit

Event Timeline

kp created this revision.Dec 24 2020, 3:47 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptDec 24 2020, 3:47 PM

kp requested review of this revision.Dec 24 2020, 3:47 PM

Harbormaster completed remote builds in B35671: Diff 81131.Dec 24 2020, 3:47 PM

kp added a child revision: D27760: pf: Change pf_krule counters to use counter_u64.Dec 24 2020, 3:50 PM

kp added a parent revision: D27758: pf: Split pf_rule into kernel and user space versions.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 5 2021, 10:38 PM

Closed by commit rGc7bdafe2f1b7: pf: Remove unused fields from pf_krule (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGc7bdafe2f1b7: pf: Remove unused fields from pf_krule.

kp added a commit: rG7ee74e43abb7: pf: Remove unused fields from pf_krule.Jan 20 2021, 2:46 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

pfvar.h

4 lines

Diff 81131

View Options

pf: Remove unused fields from pf_kruleClosedPublicActions