Page MenuHomeFreeBSD
Differential D27504

Skip the vm.pmap.kernel_maps sysctl by default.
ClosedPublic
Actions

Authored by jhb on Dec 7 2020, 11:09 PM.
Tags
None
Referenced Files
F82835148: D27504.diff
Fri, May 3, 12:20 AM
F82771323: D27504.id80914.diff
Thu, May 2, 11:23 AM
Unknown Object (File)
Thu, May 2, 4:42 AM
Unknown Object (File)
Sun, Apr 28, 12:38 AM
Unknown Object (File)
Sun, Apr 28, 12:31 AM
Unknown Object (File)
Sun, Apr 28, 12:31 AM
Unknown Object (File)
Sat, Apr 27, 8:11 PM
Unknown Object (File)
Thu, Apr 25, 8:35 PM
View All 30 Files
Subscribers
andrew
emaste
freqlabs
imp

Details

Reviewers
markj
kib
manu
Commits
rG8c3fa20b9dd8: Skip the vm.pmap.kernel_maps sysctl by default.
rS368768: Skip the vm.pmap.kernel_maps sysctl by default.
Summary

This sysctl node generates very verbose output, so don't trigger it
for sysctl -a or sysctl vm.pmap.

Test Plan
  • I tried to use 'sysctl vm.pmap' on my laptop to see the status of PTI and was flooded with many, many lines of output

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Dec 7 2020, 11:09 PM
Herald added a reviewer: manu. · View Herald TranscriptDec 7 2020, 11:09 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
jhb requested review of this revision.Dec 7 2020, 11:09 PM
Harbormaster completed remote builds in B35241: Diff 80421.Dec 7 2020, 11:09 PM
markj accepted this revision.Dec 7 2020, 11:11 PM
This revision is now accepted and ready to land.Dec 7 2020, 11:11 PM
kib accepted this revision.Dec 7 2020, 11:32 PM
jhb added a subscriber: freqlabs.Dec 18 2020, 1:38 AM

Hmm, @freqlabs, I was testing this, and I found that while 'sysctl vm' skipped this sysctl, 'sysctl vm.pmap' did not, so it seems like something is broken with the CTLFLAG_SKIP handling.

jhb added a comment.Dec 18 2020, 1:39 AM

To be clear, vm.pmap.kernel_maps is the node in question, so I would expect sysctl vm.pmap to skip it.

freqlabs added a comment.Dec 18 2020, 6:22 PM

@jhb Thanks for the heads up. It's working as intended in other cases but clearly not in this case. I'm looking into it.

Closed by commit rS368768: Skip the vm.pmap.kernel_maps sysctl by default. (authored by jhb). · Explain WhyDec 18 2020, 8:41 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS368768: Skip the vm.pmap.kernel_maps sysctl by default..
markj added a commit: rG8c3fa20b9dd8: Skip the vm.pmap.kernel_maps sysctl by default..Feb 25 2021, 4:49 PM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
2 lines
arm64/
arm64/
2 lines
i386/
i386/
2 lines
riscv/
riscv/
2 lines

Diff 80914

View Options

head/sys/amd64/amd64/pmap.c

Loading...
View Options

head/sys/arm64/arm64/pmap.c

Loading...
View Options

head/sys/i386/i386/pmap_base.c

Loading...
View Options

head/sys/riscv/riscv/pmap.c

Loading...