pf: Use counter_u64 for pf_state byte/packet tracking
ClosedPublic
Actions

Authored by kp on Dec 17 2020, 9:14 PM.

Details

Reviewers

scottl
donner
philip

Group Reviewers

network

Commits

rGea7401fe6764: pf: Use counter(9) for pf_state byte/packet tracking

Summary

This improves cache behaviour by not writing to the same variable from
multiple cores simultaneously.

pf_state is only used in the kernel, so can be safely modified.

MFC after: 1 week
Sponsed by: Orange Business Services

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35497
Build 32402: arc lint + arc unit

Event Timeline

kp created this revision.Dec 17 2020, 9:14 PM

Herald added subscribers: melifaro, farrokhi, ae, imp. · View Herald TranscriptDec 17 2020, 9:14 PM

kp requested review of this revision.Dec 17 2020, 9:14 PM

Harbormaster completed remote builds in B35497: Diff 80865.Dec 17 2020, 9:14 PM

donner accepted this revision as: donner.Dec 18 2020, 11:59 AM

This revision is now accepted and ready to land.Dec 18 2020, 11:59 AM

kp added a reviewer: philip.Dec 20 2020, 10:43 AM

This looks good. Thank you!

Committed as https://cgit.freebsd.org/src/commit/?id=1c00efe98ed7d103b9684ff692ffd5e3b64d0237

kp added a commit: rGea7401fe6764: pf: Use counter(9) for pf_state byte/packet tracking.Jan 3 2021, 9:30 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

pfvar.h

4 lines

netpfil/

pf/

if_pfsync.c

13 lines

pf.c

34 lines

pf_ioctl.c

10 lines

Diff 80865

View Options

sys/net/pfvar.h

View Options

sys/netpfil/pf/if_pfsync.c

View Options

sys/netpfil/pf/pf.c

View Options

pf: Use counter_u64 for pf_state byte/packet trackingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 80865

sys/net/pfvar.h

sys/netpfil/pf/if_pfsync.c

sys/netpfil/pf/pf.c

sys/netpfil/pf/pf_ioctl.c

pf: Use counter_u64 for pf_state byte/packet tracking
ClosedPublic
Actions

Revision Contents
Changeset List