fts_read: Handle error from a NULL return better.
ClosedPublic
Actions

Authored by bdrewery on Nov 11 2020, 11:42 PM.

Details

Reviewers

jilles
vangyzen
emaste
kevans

Commits

rS368467: fts_read: Handle error from a NULL return better.

Summary

This is addressing cases such as fts_read(3) encountering an [EIO]
from fchdir(2) when FTS_NOCHDIR is not set. That would otherwise be
seen as a successful traversal in some of these cases while silently
discarding expected work.

As noted in r264201, fts_read() does not set errno to 0 on a successful
EOF so it needs to be set before calling it. Otherwise we might see
a random error from one of the iterations.

gzip is ignoring most errors and could be improved separately.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdrewery requested review of this revision.Nov 11 2020, 11:42 PM

bdrewery created this revision.

Harbormaster completed remote builds in B34750: Diff 79447.Nov 11 2020, 11:42 PM

vangyzen accepted this revision.Nov 30 2020, 9:42 PM

This revision is now accepted and ready to land.Nov 30 2020, 9:42 PM

Closed by commit rS368467: fts_read: Handle error from a NULL return better. (authored by bdrewery). · Explain WhyDec 8 2020, 11:39 PM

This revision was automatically updated to reflect the committed changes.

bdrewery added a commit: rS368467: fts_read: Handle error from a NULL return better..

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2020, 11:39 PM

khng mentioned this in D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Jan 29 2021, 7:46 AM

Revision Contents
Changeset List

Path

Size

head/

bin/

chflags/

chflags.c

2 lines

chmod/

chmod.c

2 lines

cp/

cp.c

3 lines

ls/

ls.c

2 lines

rm/

rm.c

2 lines

setfacl/

setfacl.c

4 lines

contrib/

mtree/

create.c

4 lines

verify.c

4 lines

usr.bin/

du/

du.c

2 lines

grep/

util.c

4 lines

gzip/

gzip.c

4 lines

usr.sbin/

chown/

chown.c

2 lines

ckdist/

ckdist.c

2 lines

fmtree/

create.c

4 lines

verify.c

4 lines

setfmac/

setfmac.c

4 lines

Diff 80462

View Options

head/bin/chflags/chflags.c

This file was added.

				# Created by: Alfred Perlstein <alfred@freebsd.org>
				# $FreeBSD$

				PORTNAME= tipper
				PORTVERSION= 0.1
				CATEGORIES= www python
				MASTER_SITES= CHEESESHOP
				PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}

				MAINTAINER= alfred@freebsd.org
				COMMENT= Tracebacks for python via SIGUSR1

				LICENSE= MIT

				USES= python
				USE_PYTHON= distutils autoplist
				mvaUnsubmitted Not Done Inline Actions Please use the new USES=python syntax instead. mva: Please use the new USES=python syntax instead.

				.include <bsd.port.mk>

View Options

head/bin/chmod/chmod.c

This file was added.

				# Created by: Alfred Perlstein <alfred@freebsd.org>
				# $FreeBSD$

				PORTNAME= tipper
				PORTVERSION= 0.1
				CATEGORIES= www python
				MASTER_SITES= CHEESESHOP
				PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}

				MAINTAINER= alfred@freebsd.org
				COMMENT= Tracebacks for python via SIGUSR1

				LICENSE= MIT

				USES= python
				USE_PYTHON= distutils autoplist
				mvaUnsubmitted Not Done Inline Actions Please use the new USES=python syntax instead. mva: Please use the new USES=python syntax instead.

				.include <bsd.port.mk>

View Options

head/bin/cp/cp.c

This file was added.

				# Created by: Alfred Perlstein <alfred@freebsd.org>
				# $FreeBSD$

				PORTNAME= tipper
				PORTVERSION= 0.1
				CATEGORIES= www python
				MASTER_SITES= CHEESESHOP
				PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}

				MAINTAINER= alfred@freebsd.org
				COMMENT= Tracebacks for python via SIGUSR1

				LICENSE= MIT

				USES= python
				USE_PYTHON= distutils autoplist
				mvaUnsubmitted Not Done Inline Actions Please use the new USES=python syntax instead. mva: Please use the new USES=python syntax instead.

				.include <bsd.port.mk>

View Options

head/bin/ls/ls.c

This file was added.

				# Created by: Alfred Perlstein <alfred@freebsd.org>
				# $FreeBSD$

				PORTNAME= tipper
				PORTVERSION= 0.1
				CATEGORIES= www python
				MASTER_SITES= CHEESESHOP
				PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}

				MAINTAINER= alfred@freebsd.org
				COMMENT= Tracebacks for python via SIGUSR1

				LICENSE= MIT

				USES= python
				USE_PYTHON= distutils autoplist
				mvaUnsubmitted Not Done Inline Actions Please use the new USES=python syntax instead. mva: Please use the new USES=python syntax instead.

				.include <bsd.port.mk>