Page MenuHomeFreeBSD

fts_read: Handle error from a NULL return better.
ClosedPublic

Authored by bdrewery on Nov 11 2020, 11:42 PM.
Tags
None
Referenced Files
F132579465: D27184.id80462.diff
Sat, Oct 18, 3:33 AM
F132579445: D27184.id.diff
Sat, Oct 18, 3:33 AM
F132579432: D27184.id79447.diff
Sat, Oct 18, 3:33 AM
Unknown Object (File)
Fri, Oct 17, 5:11 PM
Unknown Object (File)
Thu, Oct 16, 5:13 AM
Unknown Object (File)
Mon, Oct 13, 3:12 PM
Unknown Object (File)
Thu, Oct 9, 8:01 AM
Unknown Object (File)
Sep 18 2025, 12:16 PM
Subscribers

Details

Summary

This is addressing cases such as fts_read(3) encountering an [EIO]
from fchdir(2) when FTS_NOCHDIR is not set. That would otherwise be
seen as a successful traversal in some of these cases while silently
discarding expected work.

As noted in r264201, fts_read() does not set errno to 0 on a successful
EOF so it needs to be set before calling it. Otherwise we might see
a random error from one of the iterations.

gzip is ignoring most errors and could be improved separately.

Sponsored by: Dell EMC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable