Page MenuHomeFreeBSD
Differential D27177

Add .cfi_{start,end}proc for RISC-V assembly functions
ClosedPublic
Actions

Authored by arichardson on Nov 11 2020, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 9:18 AM
Unknown Object (File)
Wed, Nov 5, 9:17 AM
Unknown Object (File)
Wed, Nov 5, 9:17 AM
Unknown Object (File)
Wed, Nov 5, 9:17 AM
Unknown Object (File)
Wed, Nov 5, 9:15 AM
Unknown Object (File)
Wed, Nov 5, 9:15 AM
Unknown Object (File)
Wed, Nov 5, 9:15 AM
Unknown Object (File)
Wed, Nov 5, 9:15 AM
View All Files
Subscribers
cem
imp
jrtc27

Details

Reviewers
jhb
Group Reviewers
riscv
Commits
rS368070: Add .cfi_{start,end}proc for RISC-V assembly functions
Summary

This allows GDB to print more useful backtraces when setting a breakpoint
on an assembly function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Nov 11 2020, 12:33 PM
arichardson created this revision.
Harbormaster completed remote builds in B34741: Diff 79426.Nov 11 2020, 12:33 PM
jhb accepted this revision.Nov 16 2020, 11:47 PM
This revision is now accepted and ready to land.Nov 16 2020, 11:47 PM
Closed by commit rS368070: Add .cfi_{start,end}proc for RISC-V assembly functions (authored by arichardson). · Explain WhyNov 26 2020, 5:37 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rS368070: Add .cfi_{start,end}proc for RISC-V assembly functions.
Herald added a subscriber: imp. · View Herald TranscriptNov 26 2020, 5:37 PM
cem added a subscriber: cem.Nov 26 2020, 6:07 PM

We should probably do something similar for arm/mips/i386/ppc. (Of course, I am a hypocrite here; I did the same for only amd64 in rS353959.)

jrtc27 added a subscriber: jrtc27.EditedNov 26 2020, 6:23 PM
In D27177#611740, @cem wrote:

We should probably do something similar for arm/mips/i386/ppc. (Of course, I am a hypocrite here; I did the same for only amd64 in rS353959.)

See D27088 for mips.

cem added a comment.Nov 26 2020, 6:29 PM

I just posted https://reviews.freebsd.org/D27387 for i386/ppc/arm64 as well.

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
include/
4 lines

Diff 80026

View Options

head/sys/riscv/include/asm.h

Loading...