Intended to be used with security/klee.
Details
Details
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 34604 Build 31693: arc lint + arc unit
Event Timeline
Comment Actions
This generally looks good to me. I'm curious about that should we use the libcxx from llvm project directly or from src/contrib/llvm-project.
Comment Actions
- Build libc++ from FreeBSD sources too. The ports doesn't build yet due to some bug in gllvm.
| devel/libc-bitcode/Makefile | ||
|---|---|---|
| 54 | Do we need ONLY_FOR_ARCHS? | |
| devel/libc-bitcode/Makefile | ||
|---|---|---|
| 41 | I am not sure but if DISTFILES are empty, then fetch does nothing by default. | |
Comment Actions
In general DO_NADA is leftovers in the infrastructure, and most/all of their usage has been removed, if you need to define a target with DO_NADA, then there is a bug somewhere we do need to fix
Comment Actions
- Remove DO_NADA. Use ${ARCH} variable.
- Set correct LICENSE_FILE depending on FreeBSD version.
| devel/libc-bitcode/Makefile | ||
|---|---|---|
| 50 | Should we merge do-build with post-build? | |
| devel/libc-bitcode/pkg-descr | ||
| 1 | ||
| devel/libcxx-bitcode/Makefile | ||
| 35 | ||
| 44 | We should probably check if we are on FreeBSD here. See https://www.freebsd.org/doc/en/books/porters-handbook/book.html#slow-patch | |
| devel/libcxx-bitcode/pkg-descr | ||
| 5 | ||
| devel/libc-bitcode/Makefile | ||
|---|---|---|
| 50 | I actually like it separated, but if you insist, I will merge them. | |
| devel/libc-bitcode/Makefile | ||
|---|---|---|
| 50 | I won't insist, but it might make it easier to grasp for future readers :) | |