Discourage users from using DO_NADA
ClosedPublic
Actions

Authored by 0mp on Nov 3 2020, 9:57 AM.

Tags

None

Referenced Files

	F175291271: D27072.diff
	Fri, Oct 9, 5:28 PM

	Unknown Object (File)
	Wed, Sep 30, 8:13 AM

	Unknown Object (File)
	Sun, Sep 27, 8:03 PM

	Unknown Object (File)
	Sun, Sep 27, 1:56 AM

	Unknown Object (File)
	Sat, Sep 26, 11:42 PM

	Unknown Object (File)
	Sat, Sep 26, 10:40 PM

	Unknown Object (File)
	Sat, Sep 26, 8:35 PM

	Unknown Object (File)
	Sat, Sep 26, 12:48 PM

View All Files

Subscribers

mat

Details

Reviewers

bapt

Group Reviewers

O5: Ports Framework
portmgr

Commits

rP553975: Discourage users from using DO_NADA

Summary

Discourage users from using DO_NADA

It should not be used to make targets do nothing. In such cases, it's most
likely the ports infrastructure which requires fixing.

Inspired by https://reviews.freebsd.org/D22981#604136

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

0mp created this revision.Nov 3 2020, 9:57 AM

Owners added a reviewer: O5: Ports Framework.Nov 3 2020, 9:57 AM

Herald added a reviewer: portmgr. · View Herald TranscriptNov 3 2020, 9:57 AM

Herald added a subscriber: mat. · View Herald Transcript

0mp requested review of this revision.Nov 3 2020, 9:57 AM

Harbormaster completed remote builds in B34594: Diff 79119.Nov 3 2020, 9:57 AM

bapt accepted this revision.Nov 3 2020, 9:59 AM

This revision is now accepted and ready to land.Nov 3 2020, 9:59 AM

Closed by commit rP553975: Discourage users from using DO_NADA (authored by 0mp). · Explain WhyNov 3 2020, 10:06 AM

This revision was automatically updated to reflect the committed changes.

0mp added a commit: rP553975: Discourage users from using DO_NADA.

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

bsd.port.mk

4 lines

O5: Ports Framework

Diff 79121

View Options

Discourage users from using DO_NADAClosedPublicActions