Page MenuHomeFreeBSD

[new port] devel/libc-bitcode: FreeBSD libc library compiled to a single LLVM IR bitcode file
Needs ReviewPublic

Authored by arrowd on Dec 31 2019, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 6:19 PM
Unknown Object (File)
Sun, Apr 7, 11:30 PM
Unknown Object (File)
Sun, Apr 7, 1:57 PM
Unknown Object (File)
Sat, Apr 6, 4:49 PM
Unknown Object (File)
Feb 4 2024, 9:16 AM
Unknown Object (File)
Jan 14 2024, 3:34 PM
Unknown Object (File)
Dec 20 2023, 6:19 AM
Unknown Object (File)
Dec 13 2023, 9:13 PM

Details

Reviewers
None
Group Reviewers
Contributor Reviewers (ports)
Summary

Intended to be used with security/klee.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28402
Build 26483: arc lint + arc unit

Event Timeline

Suggestions by Mikael Urankar.

linimon retitled this revision from devel/libc-bitcode: A new port. to [new port] devel/libc-bitcode: FreeBSD libc library compiled to a single LLVM IR bitcode file.Jan 5 2020, 9:44 PM

This generally looks good to me. I'm curious about that should we use the libcxx from llvm project directly or from src/contrib/llvm-project.

  • Build libc++ from FreeBSD sources too. The ports doesn't build yet due to some bug in gllvm.
0mp added inline comments.
devel/libc-bitcode/Makefile
54

Do we need ONLY_FOR_ARCHS?

devel/libc-bitcode/Makefile
41

I am not sure but if DISTFILES are empty, then fetch does nothing by default.

In general DO_NADA is leftovers in the infrastructure, and most/all of their usage has been removed, if you need to define a target with DO_NADA, then there is a bug somewhere we do need to fix

arrowd marked 2 inline comments as done.
  • Remove DO_NADA. Use ${ARCH} variable.
  • Set correct LICENSE_FILE depending on FreeBSD version.
devel/libc-bitcode/Makefile
51

Should we merge do-build with post-build?

devel/libc-bitcode/pkg-descr
2
devel/libcxx-bitcode/Makefile
36
45

We should probably check if we are on FreeBSD here. See https://www.freebsd.org/doc/en/books/porters-handbook/book.html#slow-patch

devel/libcxx-bitcode/pkg-descr
6
arrowd marked 4 inline comments as done.
  • Address comments.
  • Use shared libc as bitcode extraction source.
devel/libc-bitcode/Makefile
51

I actually like it separated, but if you insist, I will merge them.

devel/libc-bitcode/Makefile
51

I won't insist, but it might make it easier to grasp for future readers :)