Add bus_dma_iommu_set_buswide() stubs
ClosedPublic
Actions

Authored by br on Oct 21 2020, 11:37 AM.

Details

Reviewers

kib
manu

Commits

rS366980: Move the iommu stubs to a generic place, so they are available on all the

Summary

Make bus_dma_iommu_set_buswide() and bus_dma_iommu_load_ident() present unconditionally (regardless of IOMMU support availability in kernel).

Not sure if we want to include iommu.h instead of duplicating function prototypes, but this will require PCI headers as well

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br created this revision.Oct 21 2020, 11:37 AM

Herald added a reviewer: manu. · View Herald TranscriptOct 21 2020, 11:37 AM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript

br requested review of this revision.Oct 21 2020, 11:37 AM

kib accepted this revision.Oct 21 2020, 2:38 PM

This revision is now accepted and ready to land.Oct 21 2020, 2:38 PM

Would it make sense to move these to subr_bus_dma.c in the non-IOMMU case?

In D26887#599735, @andrew wrote:

Would it make sense to move these to subr_bus_dma.c in the non-IOMMU case?

I'm not sure. I guess we can't customize per-arch implementation of these functions in non-IOMMU case

In D26887#600298, @br wrote:

In D26887#599735, @andrew wrote:

Would it make sense to move these to subr_bus_dma.c in the non-IOMMU case?

I'm not sure. I guess we can't customize per-arch implementation of these functions in non-IOMMU case

This KPI does not make sense for non-IOMMU configurations. It is there only as a placeholder so that driver authors do not need to learn how to work around IOMMU absence.

Move iommu stubs to subr_bus_dma.c

This revision now requires review to proceed.Oct 23 2020, 2:35 PM

As far as this pass tinderbox ...

This revision is now accepted and ready to land.Oct 23 2020, 4:58 PM

Closed by commit rS366980: Move the iommu stubs to a generic place, so they are available on all the (authored by br). · Explain WhyOct 23 2020, 9:28 PM

This revision was automatically updated to reflect the committed changes.

br added a commit: rS366980: Move the iommu stubs to a generic place, so they are available on all the.

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2020, 9:28 PM