Page MenuHomeFreeBSD

arm64: QorIQ: gpio: Style cleanups.
ClosedPublic

Authored by ar_semihalf.com on Oct 19 2020, 7:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 12:35 AM
Unknown Object (File)
Wed, Oct 8, 5:40 AM
Unknown Object (File)
Tue, Oct 7, 4:18 AM
Unknown Object (File)
Mon, Oct 6, 6:24 PM
Unknown Object (File)
Tue, Sep 30, 10:12 AM
Unknown Object (File)
Mon, Sep 22, 8:11 AM
Unknown Object (File)
Mon, Sep 22, 8:05 AM
Unknown Object (File)
Mon, Sep 22, 7:54 AM
Subscribers

Details

Summary

Make the code more conformant to style(9) and improve the general
readability.

This patch does not alter the driver logic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sys/arm64/qoriq/ls1046_gpio.c
147

Shall we make this bool while we're here?

203

Looks like enable is a boolean; uint8_t seems a little odd.

sys/arm64/qoriq/ls1046_gpio.c
203

Yes. I would have done that, but I am getting rid of his helper altogether in D26868.

Change qoriq_make_gpio_res return type to bool.

@mmel @manu @mw Any remarks to this patch and the related ones in stack?

mmel added inline comments.
sys/arm64/qoriq/ls1046_gpio.c
528

Is not this slightly aggressive ?

This revision is now accepted and ready to land.Nov 2 2020, 9:30 AM
This revision was automatically updated to reflect the committed changes.