arm64: QorIQ: gpio: Style cleanups.
ClosedPublic
Actions

Authored by ar_semihalf.com on Oct 19 2020, 7:04 PM.

Details

Reviewers

mw
mmel
manu

Commits

rGc76c36f95c3c: arm64: QorIQ: gpio: Style cleanups

Summary

Make the code more conformant to style(9) and improve the general
readability.

This patch does not alter the driver logic.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ar_semihalf.com created this revision.Oct 19 2020, 7:04 PM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptOct 19 2020, 7:04 PM

ar_semihalf.com requested review of this revision.Oct 19 2020, 7:04 PM

ar_semihalf.com added a child revision: D26868: arm64: QorIQ: gpio: Cleanup qoriq_gpio_* helpers.Oct 19 2020, 7:08 PM

emaste added inline comments.Oct 19 2020, 7:31 PM

sys/arm64/qoriq/ls1046_gpio.c
147	Shall we make this `bool` while we're here?
203	Looks like `enable` is a boolean; `uint8_t` seems a little odd.

ar_semihalf.com added inline comments.Oct 19 2020, 7:33 PM

sys/arm64/qoriq/ls1046_gpio.c
203	Yes. I would have done that, but I am getting rid of his helper altogether in D26868.

Change qoriq_make_gpio_res return type to bool.

@mmel @manu @mw Any remarks to this patch and the related ones in stack?

mmel accepted this revision.Nov 2 2020, 9:30 AM

mmel added inline comments.

sys/arm64/qoriq/ls1046_gpio.c
528	Is not this slightly aggressive ?

This revision is now accepted and ready to land.Nov 2 2020, 9:30 AM

Closed by commit rGc76c36f95c3c: arm64: QorIQ: gpio: Style cleanups (authored by mw). · Explain WhyJan 6 2021, 9:39 PM

This revision was automatically updated to reflect the committed changes.

mw added a commit: rGc76c36f95c3c: arm64: QorIQ: gpio: Style cleanups.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

qoriq/

ls1046_gpio.c

122 lines

Diff 81775

View Options

sys/arm64/qoriq/ls1046_gpio.c

arm64: QorIQ: gpio: Style cleanups.ClosedPublicActions