Add a -R option to mountd so that it can be run without rpcbind for an NFSv4 only server
ClosedPublic
Actions

Authored by rmacklem on Oct 12 2020, 2:15 AM.

Details

Reviewers

freqlabs
gbe
asomers

Group Reviewers

manpages

Commits

rS367027: Update man page for -R option added by r376026.
rS367026: Add "-R" option to tell mountd to not register with rpcbind.

Summary

rpcbind is now considered a security risk for some sites.
Since an NFSv4 only NFS server does not need rpcbind,
it makes sense to have an option that implements this.

This patch adds a "-R" option that disables the Mount
protocol (not used by NFSv4) and does not register
with rpcbind.

Changes are required to /etc/rc.d/mountd and /etc/rc.d/nfsd.
Those will be in a separate commit.

Test Plan

Tried an assortment of configurations, both with
and without -R, to see that it works.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 34126

Event Timeline

rmacklem created this revision.Oct 12 2020, 2:15 AM

Herald added a reviewer: manpages. · View Herald TranscriptOct 12 2020, 2:15 AM

Herald added a subscriber: imp. · View Herald Transcript

rmacklem requested review of this revision.Oct 12 2020, 2:15 AM

Harbormaster completed remote builds in B34105: Diff 78120.Oct 12 2020, 2:15 AM

OK from manpages.

Fix a bug where the sig_mask being used as the
argument to sigsuspend() was set to the wrong
bits, where SIGHUP was blocked.

Harbormaster completed remote builds in B34126: Diff 78151.Oct 13 2020, 12:49 AM

emaste added a subscriber: emaste.Oct 20 2020, 2:45 PM

Added asomers@ in case he'd like ot review this.

Nice, looks good to me!

This revision is now accepted and ready to land.Oct 23 2020, 11:55 PM

The nesting is quite deep at this point, it would probably make sense to break things up a little but that's orthogonal to this change.

It looks fine to me, but I'm not very knowledgeable in this area.

Closed by commit rS367026: Add "-R" option to tell mountd to not register with rpcbind. (authored by rmacklem). · Explain WhyOct 24 2020, 10:48 PM

This revision was automatically updated to reflect the committed changes.

rmacklem added a commit: rS367026: Add "-R" option to tell mountd to not register with rpcbind..

rmacklem added a commit: rS367027: Update man page for -R option added by r376026..Oct 24 2020, 10:52 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

mountd/

	mountd.8
	mountd.8.sav

15 lines

	mountd.c
	mountd.c.sav

325 lines

Diff 78151

View Options

usr.sbin/mountd/mountd.8