riscv: De-Arm a couple of names
ClosedPublic
Actions

Authored by jrtc27 on Oct 5 2020, 12:25 PM.

Details

Reviewers

Group Reviewers

riscv

Commits

rS366484: riscv: De-Arm a few names

Summary

These names were inherited from the arm64 port and should be changed to
the RISC-V terminology.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

jrtc27 requested review of this revision.Oct 5 2020, 12:25 PM

jrtc27 created this revision.

markj added inline comments.

sys/riscv/riscv/trap.c
354 ↗	(On Diff #77880)	data_abort() also seems like an ARMism.

You missed the opportunity for a disarming pun.

This revision is now accepted and ready to land.Oct 5 2020, 12:27 PM

In D26671#594266, @kp wrote:

You missed the opportunity for a disarming pun.

Dearm is also in the OED, even if it's marked obsolete :)

Also rename data_abort.

This revision now requires review to proceed.Oct 5 2020, 12:32 PM

jrtc27 marked an inline comment as done.Oct 5 2020, 12:33 PM

jrtc27 added inline comments.

sys/riscv/riscv/trap.c
354 ↗	(On Diff #77880)	TIL :)

kp accepted this revision as: kp.Oct 5 2020, 12:33 PM

This revision is now accepted and ready to land.Oct 5 2020, 12:33 PM

jrtc27 marked an inline comment as done.Oct 5 2020, 12:35 PM

jrtc27 added inline comments.

sys/riscv/riscv/trap.c
290 ↗	(On Diff #77881)	It is odd that we don't handle instruction page faults here... I assume because of the way we map the kernel we know we _shouldn't_ get them, but currently if we do we will end up taking the default case and printing "Unknown kernel exception", which is fine but not technically true...

sys/riscv/riscv/trap.c
290 ↗	(On Diff #77881)	I was wondering about that too. I can't find a reason to not pass kernel-mode instruction fetch page faults to page_fault_handler(). vm_fault_trap() should trigger a panic in that case.