Page MenuHomeFreeBSD

riscv: De-Arm a couple of names
ClosedPublic

Authored by jrtc27 on Oct 5 2020, 12:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 12:51 PM
Unknown Object (File)
Fri, Apr 26, 11:40 AM
Unknown Object (File)
Fri, Apr 26, 11:34 AM
Unknown Object (File)
Fri, Apr 26, 11:34 AM
Unknown Object (File)
Fri, Apr 26, 7:41 AM
Unknown Object (File)
Tue, Apr 23, 10:13 AM
Unknown Object (File)
Feb 21 2024, 5:57 PM
Unknown Object (File)
Dec 23 2023, 1:56 AM
Subscribers

Details

Reviewers
kp
markj
jhb
Group Reviewers
riscv
Commits
rS366484: riscv: De-Arm a few names
Summary

These names were inherited from the arm64 port and should be changed to
the RISC-V terminology.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33996
Build 31185: arc lint + arc unit

Event Timeline

jrtc27 created this revision.
markj added inline comments.
sys/riscv/riscv/trap.c
354

data_abort() also seems like an ARMism.

kp added a subscriber: kp.

You missed the opportunity for a disarming pun.

This revision is now accepted and ready to land.Oct 5 2020, 12:27 PM
In D26671#594266, @kp wrote:

You missed the opportunity for a disarming pun.

Dearm is also in the OED, even if it's marked obsolete :)

This revision now requires review to proceed.Oct 5 2020, 12:32 PM
jrtc27 added inline comments.
sys/riscv/riscv/trap.c
354

TIL :)

This revision is now accepted and ready to land.Oct 5 2020, 12:33 PM
jrtc27 added inline comments.
sys/riscv/riscv/trap.c
290

It is odd that we don't handle instruction page faults here... I assume because of the way we map the kernel we know we _shouldn't_ get them, but currently if we do we will end up taking the default case and printing "Unknown kernel exception", which is fine but not technically true...

sys/riscv/riscv/trap.c
290

I was wondering about that too. I can't find a reason to not pass kernel-mode instruction fetch page faults to page_fault_handler(). vm_fault_trap() should trigger a panic in that case.

jhb added a subscriber: jhb.
jhb added inline comments.
sys/riscv/riscv/trap.c
290

+1

This revision was automatically updated to reflect the committed changes.