These names were inherited from the arm64 port and should be changed to
the RISC-V terminology.
Details
Details
- Reviewers
kp markj jhb - Group Reviewers
riscv - Commits
- rS366484: riscv: De-Arm a few names
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 354 ↗ | (On Diff #77880) | data_abort() also seems like an ARMism. |
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 354 ↗ | (On Diff #77880) | TIL :) |
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 290 ↗ | (On Diff #77881) | It is odd that we don't handle instruction page faults here... I assume because of the way we map the kernel we know we _shouldn't_ get them, but currently if we do we will end up taking the default case and printing "Unknown kernel exception", which is fine but not technically true... |
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 290 ↗ | (On Diff #77881) | I was wondering about that too. I can't find a reason to not pass kernel-mode instruction fetch page faults to page_fault_handler(). vm_fault_trap() should trigger a panic in that case. |
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 290 ↗ | (On Diff #77881) | +1 |