Check if_capenable, not if_capabilities.
ClosedPublic
Actions

Authored by jhb on Oct 5 2020, 9:17 PM.

Details

Reviewers

rrs
gallatin

Group Reviewers

transport

Commits

rS366492: Check if_capenable, not if_capabilities when enabling rate limiting.

Summary

if_capabilities is a read-only mask of supported capabilities.
if_capenable is a mask under administrative control via ifconfig(8).

Test Plan

Drew tested this as part of the TLS ratelimit patches

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 34008
Build 31197: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 5 2020, 9:17 PM

Herald added a reviewer: transport. · View Herald TranscriptOct 5 2020, 9:17 PM

Herald added a subscriber: melifaro. · View Herald Transcript

jhb requested review of this revision.Oct 5 2020, 9:17 PM

Harbormaster completed remote builds in B34008: Diff 77918.Oct 5 2020, 9:17 PM

jhb added a child revision: D26691: Support hardware rate limiting (pacing) with TLS offload..Oct 5 2020, 9:24 PM

gallatin accepted this revision.Oct 6 2020, 1:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2020, 6:02 PM

Closed by commit rS366492: Check if_capenable, not if_capabilities when enabling rate limiting. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS366492: Check if_capenable, not if_capabilities when enabling rate limiting..

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2020, 6:02 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_ratelimit.c

4 lines

Diff 77918

View Options

sys/netinet/tcp_ratelimit.c

Check if_capenable, not if_capabilities.ClosedPublicActions