These names were inherited from the arm64 port and should be changed to
the RISC-V terminology.
Details
Details
- Reviewers
kp markj jhb - Group Reviewers
riscv - Commits
- rS366484: riscv: De-Arm a few names
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33996 Build 31185: arc lint + arc unit
Event Timeline
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 354 | data_abort() also seems like an ARMism. | |
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 354 | TIL :) | |
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 290 | It is odd that we don't handle instruction page faults here... I assume because of the way we map the kernel we know we _shouldn't_ get them, but currently if we do we will end up taking the default case and printing "Unknown kernel exception", which is fine but not technically true... | |
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 290 | I was wondering about that too. I can't find a reason to not pass kernel-mode instruction fetch page faults to page_fault_handler(). vm_fault_trap() should trigger a panic in that case. | |
| sys/riscv/riscv/trap.c | ||
|---|---|---|
| 290 | +1 | |