Differential D26378

Move SV_ABI_ERRNO translation to linux-specific code
ClosedPublic
Actions

Authored by trasz on Sep 9 2020, 4:42 PM.

Tags

None

Referenced Files

	F135949720: D26378.diff
	Fri, Nov 14, 11:46 AM

	Unknown Object (File)
	Wed, Nov 12, 5:59 AM

	Unknown Object (File)
	Sun, Nov 9, 11:41 PM

	Unknown Object (File)
	Sun, Nov 9, 11:40 PM

	Unknown Object (File)
	Sun, Nov 9, 11:40 PM

	Unknown Object (File)
	Sun, Nov 9, 11:35 PM

	Unknown Object (File)
	Sun, Nov 9, 11:34 PM

	Unknown Object (File)
	Sat, Nov 8, 4:56 AM

Subscribers

Details

Reviewers

manu
kib
emaste

Group Reviewers

Linux Emulation

Commits

rS365755: Move SV_ABI_ERRNO translation into linux-specific code, to simplify

Summary

Move SV_ABI_ERRNO translation to linux-specific code.
No functional changes intended.

This is a dependency for https://reviews.freebsd.org/D26388.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33558
Build 30812: arc lint + arc unit

Event Timeline

trasz created this revision.Sep 9 2020, 4:42 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 9 2020, 4:42 PM

Herald added subscribers: jhibbits, emaste, andrew, imp. · View Herald Transcript

trasz requested review of this revision.Sep 9 2020, 4:42 PM

Harbormaster completed remote builds in B33466: Diff 76823.Sep 9 2020, 4:42 PM

trasz mentioned this in D26388: Get rid of sv_errtbl and SV_ABI_ERRNO().Sep 10 2020, 10:35 AM

trasz added reviewers: Linux Emulation, kib, emaste.Sep 11 2020, 10:32 AM

trasz edited the summary of this revision. (Show Details)

kib added inline comments.Sep 11 2020, 2:49 PM

sys/amd64/linux/linux_sysvec.c
225	Since you are doing such manipulations, it probably makes sense to stop use freebsd-native cpu_set_syscall_retval() in linux_set_syscall_retval, at least on i386 and amd64. From what I remember, linux convention is that both normal return and error are set in %rax/%eax, and PSL_C is not set in case of error. So we can stop corrupting PCL_C for Linux.

trasz added inline comments.Sep 11 2020, 6:25 PM

sys/amd64/linux/linux_sysvec.c
225	There's a WIP: https://reviews.freebsd.org/D26406

kib accepted this revision.Sep 11 2020, 6:58 PM

This revision is now accepted and ready to land.Sep 11 2020, 6:58 PM

Fix tinderbox.

This revision now requires review to proceed.Sep 14 2020, 10:26 AM

Harbormaster completed remote builds in B33544: Diff 77000.Sep 14 2020, 10:27 AM

Fixed tinderbox even more.

Harbormaster completed remote builds in B33558: Diff 77037.Sep 15 2020, 5:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 15 2020, 4:41 PM

Closed by commit rS365755: Move SV_ABI_ERRNO translation into linux-specific code, to simplify (authored by trasz). · Explain Why

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS365755: Move SV_ABI_ERRNO translation into linux-specific code, to simplify.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

2 lines

linux/

5 lines

linux32/

linux32_sysvec.c

16 lines

arm/

arm/

2 lines

arm64/

arm64/

2 lines

linux/

7 lines

i386/

i386/

2 lines

linux/

17 lines

powerpc/

powerpc/

2 lines

Diff 77037

sys/amd64/amd64/vm_machdep.c

Loading...

sys/amd64/linux/linux_sysvec.c

Loading...

sys/amd64/linux32/linux32_sysvec.c

Loading...

sys/arm/arm/vm_machdep.c

Loading...

sys/arm64/arm64/vm_machdep.c

Loading...

sys/arm64/linux/linux_sysvec.c

Loading...

sys/i386/i386/vm_machdep.c

Loading...

sys/i386/linux/linux_sysvec.c

Loading...

sys/powerpc/powerpc/exec_machdep.c

Loading...