Page MenuHomeFreeBSD
Differential D26382

Add basic tests for dynamic fib creation.
ClosedPublic
Actions

Authored by melifaro on Sep 9 2020, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 3, 8:00 AM
Unknown Object (File)
Sat, May 25, 9:32 PM
Unknown Object (File)
Sat, May 25, 9:32 PM
Unknown Object (File)
Sat, May 25, 9:32 PM
Unknown Object (File)
Fri, May 24, 2:31 AM
Unknown Object (File)
Sat, May 18, 5:06 AM
Unknown Object (File)
Sun, May 12, 11:38 AM
Unknown Object (File)
Sat, May 11, 9:03 AM
View All 51 Files
Subscribers
ae
asomers
bz
imp
kp

Details

Reviewers
kp
Group Reviewers
network
Commits
rS365609: Add basic test for net.fibs dynamic growth.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33473
Build 30750: arc lint + arc unit

Event Timeline

melifaro created this revision.Sep 9 2020, 9:24 PM
Herald added subscribers: bz, ae, asomers, imp. · View Herald TranscriptSep 9 2020, 9:24 PM
melifaro requested review of this revision.Sep 9 2020, 9:24 PM
Harbormaster completed remote builds in B33473: Diff 76836.Sep 9 2020, 9:24 PM
melifaro added a reviewer: network.Sep 9 2020, 9:24 PM
kp added a subscriber: kp.Sep 9 2020, 9:51 PM

Yay! Tests!

Do these need to be in a separate file rather than being added to fibs_tests?

Also, they seem to fail on my test vm with sysctl: oid 'net.fibs' is read only. I suspect you've fixed that in r365517.

tests/sys/netinet6/fibs6.sh
59

Would adding no_dad to the ifconfig also work?

melifaro added a comment.Sep 9 2020, 10:00 PM
In D26382#586634, @kp wrote:

Yay! Tests!

Do these need to be in a separate file rather than being added to fibs_tests?

fibs_tests uses different approach (no vnet, no epair) and don't exist for IPv6. I'd prefer to start with a fresh one and revisit fibs_tests tests after landing D26076 and multipath support - they might need notable changes.

tests/sys/netinet6/fibs6.sh
59

It's certainly possible, though this is more like integration test, so I'd prefer not to skip one of the steps used in prod env.

kp accepted this revision as: kp.Sep 10 2020, 6:06 AM
This revision is now accepted and ready to land.Sep 10 2020, 6:06 AM
Closed by commit rS365609: Add basic test for net.fibs dynamic growth. (authored by melifaro). · Explain WhySep 10 2020, 7:26 PM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rS365609: Add basic test for net.fibs dynamic growth..

Revision Contents
Changeset List

PathSize
tests/
sys/
netinet/
2 lines
73 lines
netinet6/
3 lines
92 lines

Diff 76836

View Options

tests/sys/netinet/Makefile

Loading...
View Options

tests/sys/netinet/fibs.sh

Loading...
View Options

tests/sys/netinet6/Makefile

Loading...
View Options

tests/sys/netinet6/fibs6.sh

Loading...