Page MenuHomeFreeBSD

Add basic tests for dynamic fib creation.
ClosedPublic

Authored by melifaro on Wed, Sep 9, 9:24 PM.

Details

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

melifaro created this revision.Wed, Sep 9, 9:24 PM
melifaro requested review of this revision.Wed, Sep 9, 9:24 PM
kp added a subscriber: kp.Wed, Sep 9, 9:51 PM

Yay! Tests!

Do these need to be in a separate file rather than being added to fibs_tests?

Also, they seem to fail on my test vm with sysctl: oid 'net.fibs' is read only. I suspect you've fixed that in r365517.

tests/sys/netinet6/fibs6.sh
59 ↗(On Diff #76836)

Would adding no_dad to the ifconfig also work?

In D26382#586634, @kp wrote:

Yay! Tests!

Do these need to be in a separate file rather than being added to fibs_tests?

fibs_tests uses different approach (no vnet, no epair) and don't exist for IPv6. I'd prefer to start with a fresh one and revisit fibs_tests tests after landing D26076 and multipath support - they might need notable changes.

tests/sys/netinet6/fibs6.sh
59 ↗(On Diff #76836)

It's certainly possible, though this is more like integration test, so I'd prefer not to skip one of the steps used in prod env.

kp accepted this revision as: kp.Thu, Sep 10, 6:06 AM
This revision is now accepted and ready to land.Thu, Sep 10, 6:06 AM
This revision was automatically updated to reflect the committed changes.