Page MenuHomeFreeBSD

Add basic tests for dynamic fib creation.
ClosedPublic

Authored by melifaro on Sep 9 2020, 9:24 PM.
Tags
None
Referenced Files
F102950029: D26382.diff
Tue, Nov 19, 2:49 AM
Unknown Object (File)
Sat, Nov 9, 10:34 PM
Unknown Object (File)
Oct 16 2024, 4:12 AM
Unknown Object (File)
Sep 17 2024, 4:04 PM
Unknown Object (File)
Sep 17 2024, 4:04 PM
Unknown Object (File)
Sep 17 2024, 4:04 PM
Unknown Object (File)
Sep 17 2024, 5:59 AM
Unknown Object (File)
Sep 16 2024, 6:11 AM
Subscribers

Details

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Yay! Tests!

Do these need to be in a separate file rather than being added to fibs_tests?

Also, they seem to fail on my test vm with sysctl: oid 'net.fibs' is read only. I suspect you've fixed that in r365517.

tests/sys/netinet6/fibs6.sh
59 ↗(On Diff #76836)

Would adding no_dad to the ifconfig also work?

In D26382#586634, @kp wrote:

Yay! Tests!

Do these need to be in a separate file rather than being added to fibs_tests?

fibs_tests uses different approach (no vnet, no epair) and don't exist for IPv6. I'd prefer to start with a fresh one and revisit fibs_tests tests after landing D26076 and multipath support - they might need notable changes.

tests/sys/netinet6/fibs6.sh
59 ↗(On Diff #76836)

It's certainly possible, though this is more like integration test, so I'd prefer not to skip one of the steps used in prod env.

This revision is now accepted and ready to land.Sep 10 2020, 6:06 AM
This revision was automatically updated to reflect the committed changes.