rtsol(d): add script for "M bit"
ClosedPublic
Actions

Authored by bz on Aug 18 2020, 10:04 AM.

Details

Reviewers

hrs
cperciva
markj

Group Reviewers

manpages
network

Commits

rS364771: rtsol(d): add script for "M bit"

Summary

While we do support the "O bit" running a script (usually to start a
dhcpv6 client) we have no options for setups which set the "M bit" for,
e.g., static address assignment as in EC2.

Duplicate most of the "O bit" logic to also start a script for the
"M bit" with the one difference: if the "M bit" is set we will not
start the script for the "O bit" as well (RFC 4861, Section 4.2).

Please not that the current implemention has the logic for run
"M script" and "O script" backwards it seems as I was too tired last
night. I'll update this soon. Meanwhile it would be good to know if
the idea and the implementation otherwise is sound.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 33075
Build 30452: arc lint + arc unit

Event Timeline

bz created this revision.Aug 18 2020, 10:04 AM

Herald added a reviewer: manpages. · View Herald TranscriptAug 18 2020, 10:04 AM

Herald added a subscriber: imp. · View Herald Transcript

bz requested review of this revision.Aug 18 2020, 10:04 AM

Harbormaster completed remote builds in B33040: Diff 75940.Aug 18 2020, 10:04 AM

bz added reviewers: hrs, cperciva, markj, network.Aug 18 2020, 10:06 AM

bz added inline comments.

usr.sbin/rtsold/rtsol.c
324	This needs to move before the "O bit" handling and check before calling the script needs to move as well into the other block with the other variable.
usr.sbin/rtsold/rtsold.8
225	This needs to move to the Fl O section and check bits.

markj added inline comments.Aug 18 2020, 2:18 PM

usr.sbin/rtsold/rtsol.c
330	Typo, RFc
usr.sbin/rtsold/rtsold.c
355	Maybe future-proof it? count = 0; for (size_t i = 0; i < nitems(scripts); i++) if (scripts[i] != NULL) count++;