Remove redeclaration found by gcc build
ClosedPublic
Actions

Authored by lwhsu on Aug 5 2020, 5:38 AM.

Details

Reviewers

erj
jhb
jacob.e.keller_intel.com

Group Reviewers

Intel Networking

Commits

rS364241: Remove redeclaration found by gcc build

Summary

Remove redeclaration found by gcc build

i40e_blink_phy_link_led is declared twice in this file.

Test Plan

Build with gcc and clang.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lwhsu created this revision.Aug 5 2020, 5:38 AM

Herald added a subscriber: ae. · View Herald TranscriptAug 5 2020, 5:38 AM

lwhsu requested review of this revision.Aug 5 2020, 5:38 AM

Harbormaster completed remote builds in B32764: Diff 75408.Aug 5 2020, 5:38 AM

lwhsu edited the summary of this revision. (Show Details)Aug 5 2020, 5:39 AM

lwhsu edited the test plan for this revision. (Show Details)

lwhsu added a reviewer: Intel Networking.

ping?

This looks correct to me. One of the folks actively working on the Intel networking drivers should take a look to make sure they're aware of it.

sys/dev/ixl/i40e_prototype.h
609–610 ↗	(On Diff #75408)	Here's the other declaration.

This revision is now accepted and ready to land.Aug 10 2020, 4:38 PM

@lwhsu: Could you, please, remove the declaration in line 610 instead? The first occurrence is in a group of other LED functions.

In D25954#577171, @krzysztof.galazka_intel.com wrote:

@lwhsu: Could you, please, remove the declaration in line 610 instead? The first occurrence is in a group of other LED functions.

Of course, I was also thinking about that but ended with choosing to remove the first one because of their locations of the definitions in i40e_common.c.

Closed by commit rS364241: Remove redeclaration found by gcc build (authored by lwhsu). · Explain WhyAug 15 2020, 3:26 AM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rS364241: Remove redeclaration found by gcc build.

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2020, 3:26 AM