Page MenuHomeFreeBSD
Differential D25959

Add support for Cortex-A76/Neoverse-N1 to hwpmc
ClosedPublic
Actions

Authored by andrew on Aug 5 2020, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 24, 7:16 PM
Unknown Object (File)
Mon, Aug 24, 8:41 AM
Unknown Object (File)
Sun, Aug 23, 4:24 PM
Unknown Object (File)
Sat, Aug 22, 3:17 PM
Unknown Object (File)
Wed, Aug 12, 10:53 PM
Unknown Object (File)
Mon, Aug 10, 3:55 AM
Unknown Object (File)
Sun, Aug 9, 6:45 PM
Unknown Object (File)
Sun, Aug 9, 1:32 PM
View All Files
Subscribers
bz
emaste
gnn
imp
mhorne

Details

Reviewers
manu
bz
Group Reviewers
arm64
pmc
Commits
rS364153: Add support for Cortex-A76/Neoverse-N1 to hwpmc
Summary

This adds support for the Cortex-A76 and Neoverse-N1 PMU counters to pmc.

While here add more PMCR_IDCODE values and check the implementers code is
correct before setting the PMU type.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32771
Build 30206: arc lint + arc unit

Event Timeline

andrew created this revision.Aug 5 2020, 3:10 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 5 2020, 3:10 PM
Herald added a subscriber: emaste. · View Herald Transcript
andrew requested review of this revision.Aug 5 2020, 3:10 PM
Harbormaster completed remote builds in B32771: Diff 75429.Aug 5 2020, 3:10 PM
andrew added a reviewer: pmc.Aug 5 2020, 3:11 PM
mhorne added a subscriber: mhorne.Aug 5 2020, 4:24 PM
emaste added a comment.Aug 10 2020, 1:15 AM

looks reasonable to me

sys/arm64/include/armreg.h
866–874

I did not check these, assume they were transcribed correctly.

bz accepted this revision as: bz.Aug 10 2020, 9:10 AM
bz added a subscriber: bz.

With the same comment as emaste had; no checks that each value is accurate

This revision is now accepted and ready to land.Aug 10 2020, 9:10 AM
Closed by commit rS364153: Add support for Cortex-A76/Neoverse-N1 to hwpmc (authored by andrew). · Explain WhyAug 12 2020, 10:17 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rS364153: Add support for Cortex-A76/Neoverse-N1 to hwpmc.
Herald added subscribers: gnn, imp. · View Herald TranscriptAug 12 2020, 10:17 AM

Revision Contents
Changeset List

PathSize
lib/
libpmc/
22 lines
sys/
arm64/
include/
15 lines
dev/
hwpmc/
24 lines
43 lines
sys/
3 lines

Diff 75429

View Options

lib/libpmc/libpmc.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...
View Options

sys/dev/hwpmc/hwpmc_arm64.c

Loading...
View Options

sys/dev/hwpmc/pmc_events.h

Loading...
View Options

sys/sys/pmc.h

Loading...