Paths

Table of Contentst

Differential D25500

savecore: accept device names without the /dev/ prefix
ClosedPublic
Actions

Authored by asomers on Jun 29 2020, 12:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 27, 3:14 PM

	Unknown Object (File)
	Sat, Apr 27, 3:14 PM

	Unknown Object (File)
	Sat, Apr 27, 11:46 AM

	Unknown Object (File)
	Sat, Apr 27, 11:37 AM

	Unknown Object (File)
	Sat, Apr 27, 11:37 AM

	Unknown Object (File)
	Sat, Apr 27, 11:07 AM

	Unknown Object (File)
	Mon, Apr 22, 10:34 PM

	Unknown Object (File)
	Mon, Apr 22, 10:20 PM

View All 23 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS362790: savecore: accept device names without the /dev/ prefix

Summary

savecore: accept device names without the /dev/ prefix

dumpon has accepted device names without the prefix ever since r291207.
Since dumpon and savecore are always paired, they ought to accept the same
arguments. Prior to this change, specifying 'dumpdev="da3"' in
/etc/rc.conf, for example, would result in dumpon working just fine but
savecore complaining that "Dump device does not exist".

PR: 247618
Sponsored by: Axcient

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jun 29 2020, 12:52 AM

Herald added a reviewer: manpages. · View Herald TranscriptJun 29 2020, 12:52 AM

Herald added a subscriber: imp. · View Herald Transcript

asomers requested review of this revision.Jun 29 2020, 12:52 AM

Harbormaster completed remote builds in B32029: Diff 73850.Jun 29 2020, 12:52 AM

Just style/typo nits. Functionally, it looks good.

sbin/savecore/savecore.c
1004 ↗	(On Diff #73850)	Should this be `else if` or on a separate line?
1175–1177 ↗	(On Diff #73850)	Seems weird to add a single-line `{}` here

This revision is now accepted and ready to land.Jun 29 2020, 4:26 AM

Also good by manpages. Thanks for this change!

Closed by commit rS362790: savecore: accept device names without the /dev/ prefix (authored by asomers). · Explain WhyJun 29 2020, 10:12 PM

This revision was automatically updated to reflect the committed changes.

asomers marked 2 inline comments as done.

asomers added a commit: rS362790: savecore: accept device names without the /dev/ prefix.

Revision Contents
Changeset List

Path

Size

head/

sbin/

savecore/

47 lines

share/

man/

man5/

6 lines

Diff 73887

head/sbin/savecore/savecore.c

Loading...

head/share/man/man5/rc.conf.5

Loading...