Page MenuHomeFreeBSD

savecore: accept device names without the /dev/ prefix
ClosedPublic

Authored by asomers on Jun 29 2020, 12:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 1:00 AM
Unknown Object (File)
Nov 8 2023, 8:37 AM
Unknown Object (File)
Oct 7 2023, 7:27 AM
Unknown Object (File)
Sep 17 2023, 7:04 AM
Unknown Object (File)
Aug 31 2023, 7:03 PM
Unknown Object (File)
Aug 31 2023, 7:02 PM
Unknown Object (File)
Aug 31 2023, 7:01 PM
Unknown Object (File)
Aug 31 2023, 6:33 PM
Subscribers

Details

Summary

savecore: accept device names without the /dev/ prefix

dumpon has accepted device names without the prefix ever since r291207.
Since dumpon and savecore are always paired, they ought to accept the same
arguments. Prior to this change, specifying 'dumpdev="da3"' in
/etc/rc.conf, for example, would result in dumpon working just fine but
savecore complaining that "Dump device does not exist".

PR: 247618
Sponsored by: Axcient

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Just style/typo nits. Functionally, it looks good.

sbin/savecore/savecore.c
1004 ↗(On Diff #73850)

Should this be else if or on a separate line?

1175–1177 ↗(On Diff #73850)

Seems weird to add a single-line {} here

This revision is now accepted and ready to land.Jun 29 2020, 4:26 AM
bcr added a subscriber: bcr.

Also good by manpages. Thanks for this change!

This revision was automatically updated to reflect the committed changes.
asomers marked 2 inline comments as done.