Page MenuHomeFreeBSD
Differential D25500

savecore: accept device names without the /dev/ prefix
ClosedPublic
Actions

Authored by asomers on Jun 29 2020, 12:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 2:56 AM
Unknown Object (File)
Mon, Nov 18, 9:41 PM
Unknown Object (File)
Oct 5 2024, 5:58 PM
Unknown Object (File)
Oct 5 2024, 1:40 PM
Unknown Object (File)
Oct 5 2024, 12:47 AM
Unknown Object (File)
Oct 4 2024, 12:33 PM
Unknown Object (File)
Oct 4 2024, 1:53 AM
Unknown Object (File)
Oct 3 2024, 9:04 PM
View All 58 Files
Subscribers
bcr
imp
markj
smh

Details

Reviewers
cem
Group Reviewers
manpages
Commits
rS362790: savecore: accept device names without the /dev/ prefix
Summary

savecore: accept device names without the /dev/ prefix

dumpon has accepted device names without the prefix ever since r291207.
Since dumpon and savecore are always paired, they ought to accept the same
arguments. Prior to this change, specifying 'dumpdev="da3"' in
/etc/rc.conf, for example, would result in dumpon working just fine but
savecore complaining that "Dump device does not exist".

PR: 247618
Sponsored by: Axcient

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32029
Build 29559: arc lint + arc unit

Event Timeline

asomers created this revision.Jun 29 2020, 12:52 AM
Herald added a reviewer: manpages. · View Herald TranscriptJun 29 2020, 12:52 AM
Herald added a subscriber: imp. · View Herald Transcript
asomers requested review of this revision.Jun 29 2020, 12:52 AM
Harbormaster completed remote builds in B32029: Diff 73850.Jun 29 2020, 12:52 AM
cem accepted this revision.Jun 29 2020, 4:26 AM

Just style/typo nits. Functionally, it looks good.

sbin/savecore/savecore.c
1004

Should this be else if or on a separate line?

1175–1177

Seems weird to add a single-line {} here

This revision is now accepted and ready to land.Jun 29 2020, 4:26 AM
bcr accepted this revision as: manpages.Jun 29 2020, 6:08 AM
bcr added a subscriber: bcr.

Also good by manpages. Thanks for this change!

Closed by commit rS362790: savecore: accept device names without the /dev/ prefix (authored by asomers). · Explain WhyJun 29 2020, 10:12 PM
This revision was automatically updated to reflect the committed changes.
asomers marked 2 inline comments as done.
asomers added a commit: rS362790: savecore: accept device names without the /dev/ prefix.

Revision Contents
Changeset List

PathSize
sbin/
savecore/
48 lines
share/
man/
man5/
6 lines

Diff 73850

View Options

sbin/savecore/savecore.c

Loading...
View Options

share/man/man5/rc.conf.5

Loading...