Differential D25400

Remove some redundant assignments and computations.
ClosedPublic
Actions

Authored by markj on Jun 22 2020, 12:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 4, 10:56 PM

	Unknown Object (File)
	Tue, Nov 4, 12:42 AM

	Unknown Object (File)
	Fri, Oct 31, 11:43 PM

	Unknown Object (File)
	Thu, Oct 30, 3:14 AM

	Unknown Object (File)
	Tue, Oct 28, 1:41 AM

	Unknown Object (File)
	Tue, Oct 28, 1:36 AM

	Unknown Object (File)
	Sat, Oct 11, 1:40 AM

	Unknown Object (File)
	Sat, Oct 11, 1:40 AM

Subscribers

Details

Reviewers

alc
kib
dougm

Commits

rS362739: Remove some redundant assignments and computations.

Summary

Reported by: alc

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31964
Build 29513: arc lint + arc unit

Event Timeline

markj created this revision.Jun 22 2020, 12:52 PM

Herald added a subscriber: emaste. · View Herald TranscriptJun 22 2020, 12:52 PM

markj requested review of this revision.Jun 22 2020, 12:52 PM

Harbormaster completed remote builds in B31872: Diff 73465.Jun 22 2020, 12:52 PM

markj added reviewers: alc, kib, dougm.Jun 22 2020, 12:52 PM

markj mentioned this in D25329: Call swap_pager_freespace() from vm_object_page_remove()..

kib accepted this revision.Jun 22 2020, 2:31 PM

kib added inline comments.

sys/dev/md/md.c
1561	I do not see much sense in asserting this, but do not object strongly.

This revision is now accepted and ready to land.Jun 22 2020, 2:31 PM

alc added inline comments.Jun 22 2020, 6:36 PM

sys/compat/linuxkpi/common/src/linux_page.c
223	AFAIK, the mips and powerpc versions of ptoa() have a single implementation that is used on both 32- and 64-bit machines, and on 64-bit machine there is no guarantee that the argument is converted to a 64-bit quantity.

Address feedback.

This revision now requires review to proceed.Jun 25 2020, 3:04 PM

Harbormaster completed remote builds in B31956: Diff 73636.Jun 25 2020, 3:04 PM

kib added inline comments.Jun 25 2020, 8:04 PM

sys/compat/linuxkpi/common/src/linux_page.c
223	I think size_t or vm_offset_t would be better there.

Use vm_offset_t instead.

Harbormaster completed remote builds in B31964: Diff 73662.Jun 25 2020, 8:24 PM

kib accepted this revision.Jun 25 2020, 8:58 PM

This revision is now accepted and ready to land.Jun 25 2020, 8:58 PM

alc accepted this revision.Jun 26 2020, 6:23 PM

alc added inline comments.

sys/compat/linuxkpi/common/src/linux_page.c
202	Here is another possible ptoa() conversion that is identical to the first.

markj marked 2 inline comments as done.Jun 28 2020, 9:23 PM

Closed by commit rS362739: Remove some redundant assignments and computations. (authored by markj). · Explain WhyJun 28 2020, 9:34 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS362739: Remove some redundant assignments and computations..

Herald added a subscriber: imp. · View Herald TranscriptJun 28 2020, 9:34 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

3 lines

dev/

md/

4 lines

Diff 73662

sys/compat/linuxkpi/common/src/linux_page.c

Loading...

sys/dev/md/md.c

Loading...