Page MenuHomeFreeBSD

Remove some redundant assignments and computations.
ClosedPublic

Authored by markj on Jun 22 2020, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 8:50 PM
Unknown Object (File)
Mon, Nov 11, 6:05 AM
Unknown Object (File)
Oct 21 2024, 1:22 PM
Unknown Object (File)
Sep 25 2024, 3:25 AM
Unknown Object (File)
Sep 18 2024, 5:05 AM
Unknown Object (File)
Sep 16 2024, 5:21 AM
Unknown Object (File)
Sep 8 2024, 12:41 PM
Unknown Object (File)
Sep 8 2024, 12:41 PM
Subscribers

Details

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31872
Build 29431: arc lint + arc unit

Event Timeline

kib added inline comments.
sys/dev/md/md.c
1561

I do not see much sense in asserting this, but do not object strongly.

This revision is now accepted and ready to land.Jun 22 2020, 2:31 PM
sys/compat/linuxkpi/common/src/linux_page.c
223

AFAIK, the mips and powerpc versions of ptoa() have a single implementation that is used on both 32- and 64-bit machines, and on 64-bit machine there is no guarantee that the argument is converted to a 64-bit quantity.

markj marked 2 inline comments as done.

Address feedback.

This revision now requires review to proceed.Jun 25 2020, 3:04 PM
sys/compat/linuxkpi/common/src/linux_page.c
223

I think size_t or vm_offset_t would be better there.

This revision is now accepted and ready to land.Jun 25 2020, 8:58 PM
alc added inline comments.
sys/compat/linuxkpi/common/src/linux_page.c
202

Here is another possible ptoa() conversion that is identical to the first.

This revision was automatically updated to reflect the committed changes.