Differential D25329

Call swap_pager_freespace() from vm_object_page_remove().
ClosedPublic
Actions

Authored by markj on Jun 17 2020, 6:36 PM.

Tags

None

Referenced Files

	F160809558: D25329.id.diff
	Sun, Jun 28, 3:00 AM

	Unknown Object (File)
	Thu, Jun 25, 1:54 AM

	Unknown Object (File)
	Sun, Jun 21, 8:58 PM

	Unknown Object (File)
	Sun, Jun 21, 4:47 PM

	Unknown Object (File)
	Mon, Jun 15, 3:39 PM

	Unknown Object (File)
	Mon, Jun 15, 3:25 PM

	Unknown Object (File)
	May 18 2026, 12:29 AM

	Unknown Object (File)
	May 18 2026, 12:29 AM

Subscribers

Details

Reviewers

alc
jeff
kib

Commits

rS362613: Call swap_pager_freespace() from vm_object_page_remove().

Summary

All vm_object_page_remove() callers, except the LinuxKPI, free swap
space when removing a range of pages from an object. I believe the
omission in the LinuxKPI is a bug: looking at the Linux implementation,
pages in the range are purged from the swap cache.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Jun 17 2020, 6:36 PM

markj created this revision.

markj added reviewers: alc, jeff, kib.Jun 17 2020, 6:42 PM

Harbormaster completed remote builds in B31781: Diff 73233.Jun 18 2020, 9:20 AM

alc accepted this revision.Jun 19 2020, 5:23 AM

This revision is now accepted and ready to land.Jun 19 2020, 5:23 AM

kib accepted this revision.Jun 19 2020, 11:19 AM

alc added inline comments.Jun 19 2020, 6:01 PM

sys/dev/md/md.c
1565 ↗	(On Diff #73233)	Isn't the round_page() redundant given the above "if" statement?

markj added inline comments.Jun 22 2020, 12:53 PM

sys/dev/md/md.c
1565 ↗	(On Diff #73233)	I believe you are right. I created D25400 for this and the other nit you pointed out.

pho added a subscriber: pho.Jun 22 2020, 1:12 PM

Closed by commit rS362613: Call swap_pager_freespace() from vm_object_page_remove(). (authored by markj). · Explain WhyJun 25 2020, 3:21 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS362613: Call swap_pager_freespace() from vm_object_page_remove()..

Herald added a subscriber: imp. · View Herald TranscriptJun 25 2020, 3:21 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

md/

2 lines

fs/

tmpfs/

5 lines

kern/

5 lines

vm/

8 lines

9 lines

Diff 73637

head/sys/dev/md/md.c

Loading...

head/sys/fs/tmpfs/tmpfs_subr.c

Loading...

head/sys/kern/uipc_shm.c

Loading...

head/sys/vm/vm_map.c

Loading...

head/sys/vm/vm_object.c

Loading...