Page MenuHomeFreeBSD

Remove some redundant assignments and computations.

Authored by markj on Jun 22 2020, 12:52 PM.


Diff Detail

rS FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib added inline comments.
1561 ↗(On Diff #73465)

I do not see much sense in asserting this, but do not object strongly.

This revision is now accepted and ready to land.Jun 22 2020, 2:31 PM
223 ↗(On Diff #73465)

AFAIK, the mips and powerpc versions of ptoa() have a single implementation that is used on both 32- and 64-bit machines, and on 64-bit machine there is no guarantee that the argument is converted to a 64-bit quantity.

markj marked 2 inline comments as done.

Address feedback.

This revision now requires review to proceed.Jun 25 2020, 3:04 PM
223 ↗(On Diff #73636)

I think size_t or vm_offset_t would be better there.

This revision is now accepted and ready to land.Jun 25 2020, 8:58 PM
alc added inline comments.
202 ↗(On Diff #73662)

Here is another possible ptoa() conversion that is identical to the first.

This revision was automatically updated to reflect the committed changes.