Catch uid and gid to the correct type for display to solve segfault in ls(1) on 32bit arches
ClosedPublic
Actions

Authored by allanjude on Jul 24 2015, 7:09 PM.

Details

Reviewers

dim
eadler
ngie
marcel

Commits

rS285857: Cast uid and gid to the correct type for display to solve segfault in ls(1)…

Summary

Fix error introduced in rS285734 that causes segfault on 'ls -n' in i386

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

allanjude updated this revision to Diff 7273.Jul 24 2015, 7:09 PM

allanjude retitled this revision from to Catch uid and gid to the correct type for display to solve segfault in ls(1) on 32bit arches.

allanjude updated this object.

allanjude edited the test plan for this revision. (Show Details)

allanjude added reviewers: eadler, dim, marcel.

allanjude added a subscriber: antoine.

Herald added a subscriber: imp. · View Herald TranscriptJul 24 2015, 7:09 PM

emaste added a subscriber: emaste.Jul 24 2015, 7:14 PM

ngie accepted this revision.Jul 24 2015, 7:24 PM

ngie added a reviewer: ngie.

ngie added a subscriber: ngie.

ngie added inline comments.

bin/ls/print.c
195	Please remove the space between the casts and the casted values

This revision is now accepted and ready to land.Jul 24 2015, 7:24 PM

Fix another error detected by clang with __printflike applied to xo_emit

Remove space between casts and values

This revision now requires review to proceed.Jul 24 2015, 7:29 PM

LGTM.

This revision is now accepted and ready to land.Jul 24 2015, 8:11 PM

Closed by commit rS285857: Cast uid and gid to the correct type for display to solve segfault in ls(1)… (authored by allanjude). · Explain WhyJul 24 2015, 8:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

bin/

ls/

print.c

2 lines

Diff 7273

View Options

Catch uid and gid to the correct type for display to solve segfault in ls(1) on 32bit archesClosedPublicActions