Differential D25132

virtio: Support non-legacy network device and queue
ClosedPublic
Actions

Authored by jrtc27 on Jun 4 2020, 7:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 7, 4:06 PM

	Unknown Object (File)
	Mon, Sep 7, 12:57 AM

	Unknown Object (File)
	Mon, Sep 7, 12:47 AM

	Unknown Object (File)
	Sun, Sep 6, 1:48 AM

	Unknown Object (File)
	Sat, Sep 5, 11:20 PM

	Unknown Object (File)
	Sat, Sep 5, 2:15 AM

	Unknown Object (File)
	Thu, Sep 3, 10:39 PM

	Unknown Object (File)
	Mon, Aug 31, 6:53 PM

Subscribers

Details

Reviewers

br
andrew
kp
brooks
jhb

Commits

rS361944: virtio: Support non-legacy network device and queue

Summary

The non-legacy interface always defines num_buffers in the header,
regardless of whether VIRTIO_NET_F_MRG_RXBUF, just leaving it unused. We
also need to ensure our virtqueue doesn't filter out VIRTIO_F_VERSION_1
during negotiation, as it supports non-legacy transports just fine. This
fixes network packet transmission on TinyEMU.

Test Plan

Network interface still works in QEMU (which provides a legacy device by
default), but now also works on a TinyEMU-based system.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31491
Build 29098: arc lint + arc unit

Event Timeline

jrtc27 requested review of this revision.Jun 4 2020, 7:02 PM

jrtc27 created this revision.

Harbormaster completed remote builds in B31491: Diff 72679.Jun 4 2020, 7:02 PM

jrtc27 added a parent revision: D25131: virtio_mmio: Negotiate the upper half of the feature bits too.Jun 4 2020, 7:02 PM

brooks accepted this revision.Jun 5 2020, 4:53 PM

This revision is now accepted and ready to land.Jun 5 2020, 4:53 PM

br accepted this revision.Jun 8 2020, 4:27 PM

jhb accepted this revision.Jun 8 2020, 9:38 PM

Closed by commit rS361944: virtio: Support non-legacy network device and queue (authored by jrtc27). · Explain WhyJun 8 2020, 9:51 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rS361944: virtio: Support non-legacy network device and queue.

Herald added a subscriber: imp. · View Herald TranscriptJun 8 2020, 9:51 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

network/

12 lines

14 lines

1 line

1 line

Diff 72679

sys/dev/virtio/network/if_vtnet.c

Loading...

sys/dev/virtio/network/if_vtnetvar.h

Loading...

sys/dev/virtio/virtio.c

Loading...

sys/dev/virtio/virtqueue.c

Loading...