Page MenuHomeFreeBSD

bridge tests: Avoid building a switching loop
ClosedPublic

Authored by kp on May 31 2020, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 26 2024, 11:12 PM
Unknown Object (File)
Dec 3 2023, 1:33 PM
Unknown Object (File)
Oct 18 2023, 3:42 AM
Unknown Object (File)
Sep 27 2023, 10:43 PM
Unknown Object (File)
Sep 27 2023, 10:41 PM
Unknown Object (File)
Sep 15 2023, 9:50 PM
Unknown Object (File)
Sep 15 2023, 9:49 PM
Unknown Object (File)
Sep 15 2023, 3:13 AM

Details

Summary

Enable STP before bringing the bridges up. This avoids a switching loop,
which has a tendency to drown out progress in userspace processes,
especially on single-core systems.

Only check that we have indeed shut down one of the looped interfaces

PR: 246448

Diff Detail

Lint
Lint Warnings
SeverityLocationCodeMessage
Warningtests/sys/net/if_bridge_test.sh:CHMOD1Invalid Executable
Unit
No Test Coverage
Build Status
Buildable 31427
Build 29046: arc lint + arc unit

Event Timeline

kp requested review of this revision.May 31 2020, 7:20 PM

We no longer require jq

LGTM.

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

This revision is now accepted and ready to land.Jun 1 2020, 3:51 PM
This revision was landed with ongoing or failed builds.Jun 1 2020, 7:26 PM
This revision was automatically updated to reflect the committed changes.

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

Yeah, but that should be its own commit.