Page MenuHomeFreeBSD

bridge tests: Avoid building a switching loop
ClosedPublic

Authored by kp on May 31 2020, 7:20 PM.

Details

Summary

Enable STP before bringing the bridges up. This avoids a switching loop,
which has a tendency to drown out progress in userspace processes,
especially on single-core systems.

Only check that we have indeed shut down one of the looped interfaces

PR: 246448

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.May 31 2020, 7:20 PM

We no longer require jq

LGTM.

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

This revision is now accepted and ready to land.Jun 1 2020, 3:51 PM
This revision was landed with ongoing or failed builds.Jun 1 2020, 7:26 PM
This revision was automatically updated to reflect the committed changes.

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

Yeah, but that should be its own commit.