Page MenuHomeFreeBSD

bridge tests: Avoid building a switching loop
ClosedPublic

Authored by kp on May 31 2020, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 25, 6:48 PM
Unknown Object (File)
Sat, Sep 20, 3:55 AM
Unknown Object (File)
Sun, Sep 14, 5:24 AM
Unknown Object (File)
Sep 5 2025, 2:32 AM
Unknown Object (File)
Sep 2 2025, 1:03 PM
Unknown Object (File)
Sep 1 2025, 9:11 PM
Unknown Object (File)
Aug 26 2025, 2:29 AM
Unknown Object (File)
Aug 15 2025, 9:03 PM

Details

Summary

Enable STP before bringing the bridges up. This avoids a switching loop,
which has a tendency to drown out progress in userspace processes,
especially on single-core systems.

Only check that we have indeed shut down one of the looped interfaces

PR: 246448

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.May 31 2020, 7:20 PM

We no longer require jq

LGTM.

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

This revision is now accepted and ready to land.Jun 1 2020, 3:51 PM
This revision was landed with ongoing or failed builds.Jun 1 2020, 7:26 PM
This revision was automatically updated to reflect the committed changes.

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

Yeah, but that should be its own commit.