bhyve(8): Add bootrom allocation abstraction
ClosedPublic
Actions

Authored by cem on Apr 14 2020, 6:50 PM.

Details

Reviewers

grehan
jhb

Group Reviewers

bhyve

Commits

rS359949: bhyve(8): Add bootrom allocation abstraction

Summary

To allow more general use of the bootrom region, separate initialization from
allocation, and allocation from loading a file.

The bootrom segment is the high 16MB of the low 4GB region.

Each allocation in the segment creates a new mapping with specified protection.
By default, allocation begins at the low end of the range. However, the
BOOTROM_ALLOC_TOP flag is provided to locate a provided bootrom in the high
region it is expected to be in.

The existing ROM-file loading code is refactored to use the new interface.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Apr 14 2020, 6:50 PM

Herald added subscribers: bcran, rgrimes. · View Herald TranscriptApr 14 2020, 6:50 PM

Harbormaster completed remote builds in B30500: Diff 70569.Apr 14 2020, 6:50 PM

cem added a child revision: D23165: bhyve(8): Add VM Generation Counter ACPI device.Apr 14 2020, 6:50 PM

cem mentioned this in D23165: bhyve(8): Add VM Generation Counter ACPI device.Apr 14 2020, 6:52 PM

grehan accepted this revision.Apr 14 2020, 8:56 PM

grehan added inline comments.

usr.sbin/bhyve/bootrom.c
59 ↗	(On Diff #70569)	The exception to first-come is the actual boot rom, which must go into the area containing the power-on reset vector. Maybe a bool parameter to request this type of allocation ? Fine for now.

This revision is now accepted and ready to land.Apr 14 2020, 8:56 PM

cem added inline comments.Apr 14 2020, 10:01 PM

usr.sbin/bhyve/bootrom.c
59 ↗	(On Diff #70569)	I think I’ve placed it in the identical region as it was before this change. I agree a flag to allocate top vs bottom would help guarantee this regardless of the order of requests.

Add a flag to allocate top, and default to bottom
Use top flag in actual bootrom logic
Fix the allocation logic to actually update the free region, which was previously absent. Oops.

This revision now requires review to proceed.Apr 14 2020, 10:49 PM

Harbormaster completed remote builds in B30508: Diff 70582.Apr 14 2020, 10:49 PM

cem edited the summary of this revision. (Show Details)Apr 14 2020, 10:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 15 2020, 1:59 AM

Closed by commit rS359949: bhyve(8): Add bootrom allocation abstraction (authored by cem). · Explain Why

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS359949: bhyve(8): Add bootrom allocation abstraction.

Herald added a subscriber: imp. · View Herald TranscriptApr 15 2020, 1:59 AM