Paths

Table of Contentst

Differential D24081

bhyve: use STAILQ in NVMe emulation
ClosedPublic
Actions

Authored by chuck on Mar 15 2020, 11:40 PM.

Tags

None

Referenced Files

	F152119773: D24081.diff
	Sun, Apr 12, 9:02 PM

	Unknown Object (File)
	Sun, Apr 12, 2:59 AM

	Unknown Object (File)
	Thu, Apr 9, 8:19 PM

	Unknown Object (File)
	Fri, Apr 3, 6:33 PM

	Unknown Object (File)
	Fri, Apr 3, 2:01 PM

	Unknown Object (File)
	Thu, Apr 2, 8:55 PM

	Unknown Object (File)
	Tue, Mar 24, 2:53 AM

	Unknown Object (File)
	Sun, Mar 22, 8:03 AM

View All 95 Files

Subscribers

Details

Reviewers

jhb
imp

Group Reviewers

Commits

rS359365: bhyve: use STAILQ in NVMe emulation

Summary

Use the standard queue(3) macros instead of hand-crafted linked list
code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chuck created this revision.Mar 15 2020, 11:40 PM

Herald added subscribers: bcran, rgrimes. · View Herald TranscriptMar 15 2020, 11:40 PM

Harbormaster completed remote builds in B29959: Diff 69557.Mar 15 2020, 11:40 PM

imp accepted this revision.Mar 15 2020, 11:42 PM

This revision is now accepted and ready to land.Mar 15 2020, 11:42 PM

jhb accepted this revision.Mar 26 2020, 5:38 PM

jhb added inline comments.

usr.sbin/bhyve/pci_nvme.c
1317 ↗	(On Diff #69557)	Either move the `assert()` above the `REMOVE` similar to the old code or axe it. `STAILQ_REMOVE_HEAD` will core dump when it dereferences the head pointer before getting to the `assert()` in the current code.

Herald added a subscriber: dab. · View Herald TranscriptMar 26 2020, 5:38 PM

chuck marked an inline comment as done.Mar 26 2020, 6:49 PM

chuck added inline comments.

usr.sbin/bhyve/pci_nvme.c
1317 ↗	(On Diff #69557)	Bah, good catch. Thanks

Closed by commit rS359365: bhyve: use STAILQ in NVMe emulation (authored by chuck). · Explain WhyMar 27 2020, 3:28 PM

This revision was automatically updated to reflect the committed changes.

chuck marked an inline comment as done.

chuck added a commit: rS359365: bhyve: use STAILQ in NVMe emulation.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyve/

18 lines

Diff 69925

head/usr.sbin/bhyve/pci_nvme.c

Loading...