Use consistent flow labels when using SYN cookies
ClosedPublic
Actions

Authored by tuexen on Mar 4 2020, 4:17 PM.

Details

Reviewers

bz
rrs
jtl
rscheff

Group Reviewers

transport

Commits

rS360768: MFC r358621:
rS358621: When using automatically generated flow labels and using TCP SYN

Summary

When using SYN cookies and automatically generating flow labels, use the same flow label for the established TCP connection as for the handshake. sc_flowlabel should always be stored in network byte order, but wasn't when only SYN cookies were used.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 29780

Event Timeline

tuexen created this revision.Mar 4 2020, 4:17 PM

Herald added a reviewer: transport. · View Herald TranscriptMar 4 2020, 4:17 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

Harbormaster completed remote builds in B29780: Diff 69160.Mar 4 2020, 4:17 PM

bz accepted this revision.Mar 4 2020, 4:29 PM

This revision is now accepted and ready to land.Mar 4 2020, 4:29 PM

Closed by commit rS358621: When using automatically generated flow labels and using TCP SYN (authored by tuexen). · Explain WhyMar 4 2020, 4:41 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS358621: When using automatically generated flow labels and using TCP SYN.

tuexen added a commit: rS360768: MFC r358621:.May 7 2020, 3:29 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

3 lines

Diff 69160

View Options

sys/netinet/tcp_syncache.c

	Show First 20 Lines • Show All 207 Lines • ▼ Show 20 Lines
	options FDT			options FDT
	makeoptions MODULES_EXTRA+="dtb/sifive"			makeoptions MODULES_EXTRA+="dtb/sifive"

	# I2C support			# I2C support
	device iicbus # Bus support, required for iicoc below.			device iicbus # Bus support, required for iicoc below.
	device iicoc # OpenCores I2C controller support			device iicoc # OpenCores I2C controller support

	# Allwinner device drivers			# Allwinner device drivers
				device aw_ccu # Allwinner clock controller
				device aw_rtc # Allwinner Real-time Clock
	device aw_wdog # Allwinner Watchdog			device aw_wdog # Allwinner Watchdog
	files "../allwinner/files.allwinner"			files "../allwinner/files.allwinner"

	# SiFive device drivers			# SiFive device drivers
	device fu740_pci_dw			device fu740_pci_dw
	device sifive_gpio			device sifive_gpio
	device sifive_spi			device sifive_spi
	include "../sifive/std.sifive"			include "../sifive/std.sifive"

Use consistent flow labels when using SYN cookiesClosedPublicActions