[aacraid] Add missing aac_unmap_command() call for SYNC mode
ClosedPublic
Actions

Authored by luporl on Feb 13 2020, 6:12 PM.

Details

Reviewers

scottl
jhibbits

Commits

rS358613: [aacraid] Add missing unmap call for SYNC mode

Summary

On a PowerPC64 with an Adaptec RAID Controller with PCI device ID 0x028d, after several read/write operations, the kernel was panic'ing in bus_dmamap_sync().
This was due to a missing aac_unmap_command() in the SYNC path.

There is a work in progress (PR 237463) to make aacraid driver compatible with big-endian/PowerPC, in which this issue was found.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

luporl created this revision.Feb 13 2020, 6:12 PM

Herald added subscribers: alfredo, bdragon. · View Herald TranscriptFeb 13 2020, 6:12 PM

Harbormaster completed remote builds in B29355: Diff 68261.Feb 13 2020, 6:12 PM

luporl mentioned this in D23887: [aacraid] Port driver to big-endian.Feb 28 2020, 7:37 PM

Yes, the similar path in aac.c has

			aac_remove_busy(cm);
 			aac_unmap_command(cm);

In D23668#525565, @emaste wrote:
Yes, the similar path in aac.c has
			aac_remove_busy(cm);
 			aac_unmap_command(cm);

Right, but as in aacraid.c sync commands don't call aac_enqueue_busy(cm), aac_remove_busy(cm) should not be called when they complete.

jhibbits accepted this revision.Mar 3 2020, 5:47 PM

This revision is now accepted and ready to land.Mar 3 2020, 5:47 PM

Closed by commit rS358613: [aacraid] Add missing unmap call for SYNC mode (authored by luporl). · Explain WhyMar 4 2020, 12:22 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS358613: [aacraid] Add missing unmap call for SYNC mode.

Herald added a subscriber: imp. · View Herald TranscriptMar 4 2020, 12:22 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

aacraid/

aacraid.c

1 line

Diff 69152

View Options

head/sys/dev/aacraid/aacraid.c

[aacraid] Add missing aac_unmap_command() call for SYNC modeClosedPublicActions