Page MenuHomeFreeBSD

[aacraid] Add missing aac_unmap_command() call for SYNC mode
ClosedPublic

Authored by luporl on Feb 13 2020, 6:12 PM.
Referenced Files
Unknown Object (File)
Feb 24 2024, 9:42 AM
Unknown Object (File)
Feb 24 2024, 9:42 AM
Unknown Object (File)
Feb 24 2024, 9:41 AM
Unknown Object (File)
Feb 24 2024, 9:23 AM
Unknown Object (File)
Feb 8 2024, 10:54 AM
Unknown Object (File)
Jan 13 2024, 3:24 AM
Unknown Object (File)
Dec 22 2023, 10:34 PM
Unknown Object (File)
Dec 19 2023, 1:21 AM

Details

Summary

On a PowerPC64 with an Adaptec RAID Controller with PCI device ID 0x028d, after several read/write operations, the kernel was panic'ing in bus_dmamap_sync().
This was due to a missing aac_unmap_command() in the SYNC path.

There is a work in progress (PR 237463) to make aacraid driver compatible with big-endian/PowerPC, in which this issue was found.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Yes, the similar path in aac.c has

			aac_remove_busy(cm);
 			aac_unmap_command(cm);

Yes, the similar path in aac.c has

			aac_remove_busy(cm);
 			aac_unmap_command(cm);

Right, but as in aacraid.c sync commands don't call aac_enqueue_busy(cm), aac_remove_busy(cm) should not be called when they complete.

This revision is now accepted and ready to land.Mar 3 2020, 5:47 PM
This revision was automatically updated to reflect the committed changes.