Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic
Actions

Authored by kaktus on Feb 26 2020, 3:17 PM.

Details

Reviewers

kib
jmg
cem

Group Reviewers

csprng
O3: Kernel Random Numbers Generator	(Owns No Changed Paths)

Commits

rS358379: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (18 of many)

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.
Mark obvious cases as MPSAFE. All entries that haven't been marked as MPSAFE before are by default marked as NEEDGIANT.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kaktus created this revision.Feb 26 2020, 3:17 PM

Herald added a reviewer: jmg. · View Herald TranscriptFeb 26 2020, 3:17 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B29625: Diff 68842.Feb 26 2020, 3:17 PM

Use full context diff.

emaste edited reviewers, added: csprng; removed: secteam.Feb 26 2020, 3:23 PM

cem accepted this revision.Feb 26 2020, 4:56 PM

cem added a subscriber: cem.

cem added inline comments.

sys/dev/random/fortuna.c
305	I think mpsafe is fine here.
sys/dev/random/random_harvestq.c
114	Kinda feels like NODE type sysctls should be MPSAFE globally. The weird exceptions with handlers should have to opt out of mpsafe. Imo.
309	Sure. There is some trivial conversion to atomic update here but that’s not the goal of this patch series.
331	MPSAFE
393	MPSAFE

This revision is now accepted and ready to land.Feb 26 2020, 4:56 PM

OK, I'll mark them as mpsafe in a commit.

sys/dev/random/random_harvestq.c
114	Too late, this is the last patch in the whole series of adding NEEDGIANT :-) I'll invite you to a brainstorming review for a proposed decoupling of nodes with handlers so this mess could be removed.