[aacraid] Prevent sense data from causing a buffer overflow
ClosedPublic
Actions

Authored by luporl on Feb 13 2020, 5:59 PM.

Tags

Referenced Files

	F84296347: D23667.id69077.diff
	Tue, May 21, 11:16 PM

	F84296344: D23667.id68260.diff
	Tue, May 21, 11:16 PM

	F84296336: D23667.id.diff
	Tue, May 21, 11:16 PM

	F84295416: D23667.diff
	Tue, May 21, 10:58 PM

	Unknown Object (File)
	Tue, Apr 23, 8:31 PM

	Unknown Object (File)
	Mar 19 2024, 3:40 PM

	Unknown Object (File)
	Mar 19 2024, 2:51 PM

	Unknown Object (File)
	Dec 20 2023, 6:15 AM

Subscribers

Details

Reviewers

scottl
emaste

Commits

rS358550: [aacraid] Prevent sense data from causing a buffer overflow

Summary

On a PowerPC64 with an Adaptec RAID Controller with PCI device ID 0x028d, sense data was causing a buffer overflow, because of wrong max sense length logic.

There is a work in progress to make aacraid driver compatible with big-endian/PowerPC, in which this issue was found.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29354
Build 27253: arc lint + arc unit

Event Timeline

luporl created this revision.Feb 13 2020, 5:59 PM

Herald added subscribers: alfredo, bdragon. · View Herald TranscriptFeb 13 2020, 5:59 PM

Harbormaster completed remote builds in B29354: Diff 68260.Feb 13 2020, 5:59 PM

luporl added a reviewer: scottl.Feb 13 2020, 6:04 PM

luporl added a subscriber: jhibbits.

luporl mentioned this in D23887: [aacraid] Port driver to big-endian.Feb 28 2020, 7:37 PM

emaste accepted this revision.Mar 1 2020, 7:56 PM

This revision is now accepted and ready to land.Mar 1 2020, 7:56 PM

Closed by commit rS358550: [aacraid] Prevent sense data from causing a buffer overflow (authored by luporl). · Explain WhyMar 2 2020, 4:11 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS358550: [aacraid] Prevent sense data from causing a buffer overflow.

Herald added a subscriber: imp. · View Herald TranscriptMar 2 2020, 4:11 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

aacraid/

aacraid_cam.c

2 lines

Diff 68260

View Options

sys/dev/aacraid/aacraid_cam.c

[aacraid] Prevent sense data from causing a buffer overflowClosedPublicActions