Differential D23615
This adds wulf7 / iichid on github to ports Authored by koobs on Feb 11 2020, 5:25 AM. Tags None Referenced Files
Details As suggested on twitter here is a port for iichid maintained at https://github.com/wulf7/iichid. How to use it can be found at https://larastechlab.blogspot.com/2020/01/i2c-touchpads-on-freebsd-130-current.html. I'm more than willing to give maintainership to someone who uses it. Documentation is sketchy, hence very little here. I don't plan to put much more work into this than what is already here; anyone can claim the port for care and feeding. Someone will need to test it as I don't have the hardware.
Diff Detail
Event TimelineComment Actions Replaced MAINTAINER= cy@freebsd.org with ports@freebsd.org. I don't have the hardware and I'm not interested in maintaining it. Anyone else can. Comment Actions I'll help to get this landed in ports and can make the MAINTAINER change if Cy doesn't have cycles Comment Actions Just adding review comments for posterity. I'll take this and land it with my commented changes this evening
Comment Actions @wulf : Do you think it's time to put this into base or let's add this as a port first? Comment Actions Putting it to base requires D22901 and some extra work to separate HID into own subsystem. First is currently stalled due to my new year vacations lasted too long and second is not started yet and will make iichid non MFC-able. So it definitely must be added as a port. Comment Actions I recommend to disable USB backend by default and leave it as build-time option as it is not completed yet and interferes with existing USB drivers. It can be disabled with sed -i'' -e '/usbhid.c/s/^/#/' Makefile Comment Actions Fails building in 11amd64 with the following, so will at least set OSVERSION > 12* unless its expected or desirable for iichid to be test on 11: cc -O2 -pipe -fno-strict-aliasing -DHID_DEBUG -DIICHID_DEBUG -DEVDEV_SUPPORT -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/usr/src/sys -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD -MF.depend.hms.o -MThms.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 -c hms.c -o hms.o
hms.c:489:1: error: conflicting types for 'hms_ev_open'
hms_ev_open(struct evdev_dev *evdev)
^
hms.c:126:21: note: previous declaration is here
static evdev_open_t hms_ev_open;
^
hms.c:491:26: warning: implicit declaration of function 'evdev_get_softc' is invalid in C99 [-Wimplicit-function-declaration]
struct hms_info *info = evdev_get_softc(evdev);
^
hms.c:491:26: warning: this function declaration is not a prototype [-Wstrict-prototypes]
hms.c:491:19: warning: incompatible integer to pointer conversion initializing 'struct hms_info *' with an expression of type 'int' [-Wint-conversion]
struct hms_info *info = evdev_get_softc(evdev);
^ ~~~~~~~~~~~~~~~~~~~~~~
hms.c:505:1: error: conflicting types for 'hms_ev_close'
hms_ev_close(struct evdev_dev *evdev)
^
hms.c:127:22: note: previous declaration is here
static evdev_close_t hms_ev_close;
^
hms.c:507:26: warning: implicit declaration of function 'evdev_get_softc' is invalid in C99 [-Wimplicit-function-declaration]
struct hms_info *info = evdev_get_softc(evdev);
^
hms.c:507:19: warning: incompatible integer to pointer conversion initializing 'struct hms_info *' with an expression of type 'int' [-Wint-conversion]
struct hms_info *info = evdev_get_softc(evdev);
^ ~~~~~~~~~~~~~~~~~~~~~~
5 warnings and 2 errors generated.
*** [hms.o] Error code 1
make[1]: stopped in /wrkdirs/usr/ports/sysutils/iichid/work/iichid-699a41b
--- iichid.o ---
iichid.c:184:11: warning: implicit declaration of function 'acpi_EvaluateDSM' is invalid in C99 [-Wimplicit-function-declaration]
status = acpi_EvaluateDSM(handle, dsm_guid, 1, 1, NULL, &acpi_buf);
^
iichid.c:184:11: warning: this function declaration is not a prototype [-Wstrict-prototypes]
2 warnings generated.
1 errorComment Actions Roger that thank you. Will set OSREL > 12.1 for now and ONLY_FOR_ARCHS=amd64 i386 aarch64 Port landing shortly One question though. Since packages are build on 12.0 for all subsequent releases, wont this cause the package not to be built (since its on 12.0 host) ? | ||||||||||||||||||||||||||||||||||||||||||||||