Page MenuHomeFreeBSD
Differential D23328

Don't enable interrupts in init_secondary().
ClosedPublic
Actions

Authored by markj on Jan 22 2020, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 24, 7:12 PM
Unknown Object (File)
Nov 28 2025, 3:18 AM
Unknown Object (File)
Nov 24 2025, 4:45 AM
Unknown Object (File)
Nov 24 2025, 2:28 AM
Unknown Object (File)
Nov 23 2025, 8:51 PM
Unknown Object (File)
Nov 20 2025, 10:53 PM
Unknown Object (File)
Nov 20 2025, 10:53 PM
Unknown Object (File)
Nov 20 2025, 10:53 PM
View All 59 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
kib
andrew
Group Reviewers
arm64
Commits
rS357048: arm64: Don't enable interrupts in init_secondary().
Summary

Doing so can cause deadlocks or panics during boot. In QEMU I was
seeing occasional panics during boot when a statclock interrupt
interrupted an idle thread in init_secondary(), before per-CPU scheduler
data structures were linked. It also seemed to be causing some
mysterious boot failures in AWS but I don't have console access and so
cannot confirm.

The idle threads are set up to release a spinlock section and enable
interrupts in fork_exit(), so there is no need to enable interrupts
earlier.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
6 lines

Diff 67206

View Options

head/sys/arm64/arm64/mp_machdep.c

Loading...